Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: testing/scripts/run_telemetry_benchmark_as_googletest.py

Issue 1513943002: Skip the screenshot_sync test properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/screenshot_sync_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/scripts/run_telemetry_benchmark_as_googletest.py
diff --git a/testing/scripts/run_telemetry_benchmark_as_googletest.py b/testing/scripts/run_telemetry_benchmark_as_googletest.py
index 571542224c74de34dac38d707b34cccbc822ff3b..39af8f015dbc81fa5a14e696d8790478c06e3002 100755
--- a/testing/scripts/run_telemetry_benchmark_as_googletest.py
+++ b/testing/scripts/run_telemetry_benchmark_as_googletest.py
@@ -80,6 +80,9 @@ def main():
if not valid and not failures:
failures = ['(entire test suite)']
+ if rc == 0:
+ rc = 1 # Signal an abnormal exit.
+
json.dump({
'valid': valid,
'failures': failures,
« no previous file with comments | « content/test/gpu/gpu_tests/screenshot_sync_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698