Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1513703002: Revert of Make NVPR a GL context option instead of a GL context (Closed)

Created:
5 years ago by borenet
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-02-other-tests-refactor
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make NVPR a GL context option instead of a GL context (patchset #9 id:160001 of https://codereview.chromium.org/1448883002/ ) Reason for revert: "Could not create surface" on Linux GTX660 bots Original issue's description: > Make NVPR a GL context option instead of a GL context > > Make NVPR a GL context option instead of a GL context. > This may enable NVPR to be run with command buffer > interface. > > No functionality change in DM or nanobench. NVPR can > only be run with normal GL APIs. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/eeebdb538d476c1bfc8b63a946094ca1b505ecd1 > > Committed: https://skia.googlesource.com/skia/+/64492c43c3faee7ab0f69b1c84e0267616f85e52 TBR=mtklein@google.com,bsalomon@google.com,jvanverth@google.com,scroggo@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/9d66696f6b1651b52adad1b0202aca013ef7da58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -132 lines) Patch
M bench/nanobench.h View 1 chunk +0 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 7 chunks +25 lines, -37 lines 0 comments Download
M dm/DM.cpp View 5 chunks +15 lines, -25 lines 0 comments Download
M dm/DMGpuSupport.h View 3 chunks +2 lines, -8 lines 0 comments Download
M dm/DMSrcSink.h View 1 chunk +6 lines, -8 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +12 lines, -16 lines 0 comments Download
M src/gpu/GrContextFactory.h View 4 chunks +23 lines, -23 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
borenet
Created Revert of Make NVPR a GL context option instead of a GL context
5 years ago (2015-12-09 15:03:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513703002/1
5 years ago (2015-12-09 15:03:41 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-09 15:03:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9d66696f6b1651b52adad1b0202aca013ef7da58

Powered by Google App Engine
This is Rietveld 408576698