Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 151363004: A64: Remove two TODOs that will not be done. (Closed)

Created:
6 years, 10 months ago by Alexandre Rames
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Remove two TODOs that will not be done. - For the LDP/STP TODO: The arguments need dereferencing, so using LDP/STP would require some additional checks. - For the constant pools TODO: Unless we need to, there is no benefit from trying to generate constant pools more often, as it would likely only pollute the I-cache. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/a64/assembler-a64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/a64/builtins-a64.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexandre Rames
6 years, 10 months ago (2014-02-12 11:28:29 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-12 11:33:58 UTC) #2
Alexandre Rames
6 years, 10 months ago (2014-02-12 11:55:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698