src/a64/assembler-a64.cc - Issue 151363004: A64: Remove two TODOs that will not be done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/assembler-a64.cc

Issue 151363004: A64: Remove two TODOs that will not be done. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/a64/assembler-a64.cc

diff --git a/src/a64/assembler-a64.cc b/src/a64/assembler-a64.cc

index f2cc1077bb1d459f222733938cf1ca021306624b..c06fbe900bf19cd8b57cdfbdd68039d541d68aee 100644

--- a/src/a64/assembler-a64.cc

+++ b/src/a64/assembler-a64.cc

@@ -2354,9 +2354,6 @@ void Assembler::BlockConstPoolFor(int instructions) {

}

-// TODO(all): We are never trying to emit constant pools after unconditional

-// branches, because we only call it from Assembler::Emit() (or manually).

-// We should try to enable that.

void Assembler::CheckConstPool(bool force_emit, bool require_jump) {

// Some short sequence of instruction mustn't be broken up by constant pool

// emission, such sequences are protected by calls to BlockConstPoolFor and

« no previous file with comments | « no previous file | src/a64/builtins-a64.cc » ('j') | no next file with comments »