third_party/WebKit/Source/core/layout/LayoutPart.h - Issue 1513573013: Don't call LayoutPart::widgetPositionsUpdated unnecessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutPart.h

Issue 1513573013: Don't call LayoutPart::widgetPositionsUpdated unnecessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutPart.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.h b/third_party/WebKit/Source/core/layout/LayoutPart.h

index 1cefde91ab3c60798afca54ee489f3ccce4d37a6..385c41c21195d3de7431839e3872ed051d132895 100644

--- a/third_party/WebKit/Source/core/layout/LayoutPart.h

+++ b/third_party/WebKit/Source/core/layout/LayoutPart.h

@@ -47,9 +47,7 @@ public:

Widget* widget() const;

void updateOnWidgetChange();

- void updateWidgetPosition();

- void widgetPositionsUpdated();

- bool updateWidgetGeometry();

+ void updateWidgetGeometry();

bool isLayoutPart() const final { return true; }

virtual void paintContents(const PaintInfo&, const LayoutPoint&) const;

@@ -68,6 +66,7 @@ protected:

void invalidatePaintOfSubtreesIfNeeded(PaintInvalidationState&) override;

private:

+ bool updateWidgetGeometryInternal();

CompositingReasons additionalCompositingReasons() const override;

void willBeDestroyed() final;

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutPart.cpp » ('j') | no next file with comments »