Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutPart.h

Issue 1513573013: Don't call LayoutPart::widgetPositionsUpdated unnecessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Simon Hausmann <hausmann@kde.org> 3 * (C) 2000 Simon Hausmann <hausmann@kde.org>
4 * Copyright (C) 2006, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2006, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 29 matching lines...) Expand all
40 bool needsPreferredWidthsRecalculation() const final; 40 bool needsPreferredWidthsRecalculation() const final;
41 41
42 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override; 42 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
43 43
44 void ref() { ++m_refCount; } 44 void ref() { ++m_refCount; }
45 void deref(); 45 void deref();
46 46
47 Widget* widget() const; 47 Widget* widget() const;
48 48
49 void updateOnWidgetChange(); 49 void updateOnWidgetChange();
50 void updateWidgetPosition(); 50 void updateWidgetGeometry();
51 void widgetPositionsUpdated();
52 bool updateWidgetGeometry();
53 51
54 bool isLayoutPart() const final { return true; } 52 bool isLayoutPart() const final { return true; }
55 virtual void paintContents(const PaintInfo&, const LayoutPoint&) const; 53 virtual void paintContents(const PaintInfo&, const LayoutPoint&) const;
56 54
57 bool isThrottledFrameView() const; 55 bool isThrottledFrameView() const;
58 56
59 protected: 57 protected:
60 PaintLayerType layerTypeRequired() const override; 58 PaintLayerType layerTypeRequired() const override;
61 59
62 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) final; 60 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) final;
63 void layout() override; 61 void layout() override;
64 void paint(const PaintInfo&, const LayoutPoint&) const override; 62 void paint(const PaintInfo&, const LayoutPoint&) const override;
65 CursorDirective getCursor(const LayoutPoint&, Cursor&) const final; 63 CursorDirective getCursor(const LayoutPoint&, Cursor&) const final;
66 64
67 // Overridden to invalidate the child frame if any. 65 // Overridden to invalidate the child frame if any.
68 void invalidatePaintOfSubtreesIfNeeded(PaintInvalidationState&) override; 66 void invalidatePaintOfSubtreesIfNeeded(PaintInvalidationState&) override;
69 67
70 private: 68 private:
69 bool updateWidgetGeometryInternal();
71 CompositingReasons additionalCompositingReasons() const override; 70 CompositingReasons additionalCompositingReasons() const override;
72 71
73 void willBeDestroyed() final; 72 void willBeDestroyed() final;
74 void destroy() final; 73 void destroy() final;
75 74
76 bool setWidgetGeometry(const LayoutRect&); 75 bool setWidgetGeometry(const LayoutRect&);
77 76
78 bool nodeAtPointOverWidget(HitTestResult&, const HitTestLocation& locationIn Container, const LayoutPoint& accumulatedOffset, HitTestAction); 77 bool nodeAtPointOverWidget(HitTestResult&, const HitTestLocation& locationIn Container, const LayoutPoint& accumulatedOffset, HitTestAction);
79 78
80 int m_refCount; 79 int m_refCount;
81 }; 80 };
82 81
83 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutPart, isLayoutPart()); 82 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutPart, isLayoutPart());
84 83
85 } // namespace blink 84 } // namespace blink
86 85
87 #endif // LayoutPart_h 86 #endif // LayoutPart_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutPart.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698