Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1513573005: Provide std::move() in compat instead of using crashpad::move() (Closed)

Created:
5 years ago by Mark Mentovai
Modified:
5 years ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Provide std::move() in compat instead of using crashpad::move() This more-natural spelling doesn’t require Crashpad developers to have to remember anything special when writing code in Crashpad. It’s easier to grep for and it’s easier to remove the “compat” part when pre-C++11 libraries are no longer relevant. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/583d1dc3efa96ea50f62afa69a598eeed1534edc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -300 lines) Patch
M client/crash_report_database_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M client/crashpad_client_mac.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M client/settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M compat/compat.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A + compat/non_cxx11_lib/type_traits View 1 chunk +18 lines, -12 lines 0 comments Download
A compat/non_cxx11_lib/utility View 1 chunk +46 lines, -0 lines 0 comments Download
M handler/crash_report_upload_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M handler/handler_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M handler/mac/exception_handler_server.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M minidump/minidump_crashpad_info_writer.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M minidump/minidump_crashpad_info_writer_test.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M minidump/minidump_exception_writer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M minidump/minidump_file_writer.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M minidump/minidump_file_writer_test.cc View 12 chunks +18 lines, -18 lines 0 comments Download
M minidump/minidump_handle_writer_test.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M minidump/minidump_memory_info_writer_test.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M minidump/minidump_memory_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 8 chunks +12 lines, -11 lines 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M minidump/minidump_module_crashpad_info_writer.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M minidump/minidump_module_crashpad_info_writer_test.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M minidump/minidump_module_writer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 10 chunks +22 lines, -21 lines 0 comments Download
M minidump/minidump_rva_list_writer_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer_test.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M minidump/minidump_string_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 9 chunks +8 lines, -8 lines 0 comments Download
M minidump/minidump_thread_writer.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 12 chunks +26 lines, -26 lines 0 comments Download
M snapshot/test/test_process_snapshot.h View 4 chunks +3 lines, -3 lines 0 comments Download
M snapshot/test/test_thread_snapshot.h View 3 chunks +2 lines, -4 lines 0 comments Download
M test/win/win_child_process.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/crashpad_database_util.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M util/mach/child_port_handshake.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/child_port_handshake.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M util/net/http_transport.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M util/net/http_transport_test.cc View 6 chunks +9 lines, -6 lines 0 comments Download
D util/stdlib/move.h View 1 chunk +0 lines, -54 lines 0 comments Download
M util/util.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M util/win/exception_handler_server.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Mark Mentovai
I know how evil it is to insert your own stuff into namespace std, but ...
5 years ago (2015-12-09 16:52:48 UTC) #3
scottmg
lgtm
5 years ago (2015-12-09 18:35:44 UTC) #4
Mark Mentovai
5 years ago (2015-12-09 22:36:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
583d1dc3efa96ea50f62afa69a598eeed1534edc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698