Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: minidump/minidump_rva_list_writer_test.cc

Issue 1513573005: Provide std::move() in compat instead of using crashpad::move() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_rva_list_writer.h" 15 #include "minidump/minidump_rva_list_writer.h"
16 16
17 #include <utility>
18
17 #include "base/format_macros.h" 19 #include "base/format_macros.h"
18 #include "base/strings/stringprintf.h" 20 #include "base/strings/stringprintf.h"
19 #include "gtest/gtest.h" 21 #include "gtest/gtest.h"
20 #include "minidump/test/minidump_rva_list_test_util.h" 22 #include "minidump/test/minidump_rva_list_test_util.h"
21 #include "minidump/test/minidump_writable_test_util.h" 23 #include "minidump/test/minidump_writable_test_util.h"
22 #include "util/file/string_file.h" 24 #include "util/file/string_file.h"
23 #include "util/stdlib/move.h"
24 25
25 namespace crashpad { 26 namespace crashpad {
26 namespace test { 27 namespace test {
27 namespace { 28 namespace {
28 29
29 class TestMinidumpRVAListWriter final : public internal::MinidumpRVAListWriter { 30 class TestMinidumpRVAListWriter final : public internal::MinidumpRVAListWriter {
30 public: 31 public:
31 TestMinidumpRVAListWriter() : MinidumpRVAListWriter() {} 32 TestMinidumpRVAListWriter() : MinidumpRVAListWriter() {}
32 ~TestMinidumpRVAListWriter() override {} 33 ~TestMinidumpRVAListWriter() override {}
33 34
34 void AddChild(uint32_t value) { 35 void AddChild(uint32_t value) {
35 auto child = make_scoped_ptr(new TestUInt32MinidumpWritable(value)); 36 auto child = make_scoped_ptr(new TestUInt32MinidumpWritable(value));
36 MinidumpRVAListWriter::AddChild(crashpad::move(child)); 37 MinidumpRVAListWriter::AddChild(std::move(child));
37 } 38 }
38 39
39 private: 40 private:
40 DISALLOW_COPY_AND_ASSIGN(TestMinidumpRVAListWriter); 41 DISALLOW_COPY_AND_ASSIGN(TestMinidumpRVAListWriter);
41 }; 42 };
42 43
43 TEST(MinidumpRVAListWriter, Empty) { 44 TEST(MinidumpRVAListWriter, Empty) {
44 TestMinidumpRVAListWriter list_writer; 45 TestMinidumpRVAListWriter list_writer;
45 46
46 StringFile string_file; 47 StringFile string_file;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 const uint32_t* child = MinidumpWritableAtRVA<uint32_t>( 95 const uint32_t* child = MinidumpWritableAtRVA<uint32_t>(
95 string_file.string(), list->children[index]); 96 string_file.string(), list->children[index]);
96 ASSERT_TRUE(child); 97 ASSERT_TRUE(child);
97 EXPECT_EQ(kValues[index], *child); 98 EXPECT_EQ(kValues[index], *child);
98 } 99 }
99 } 100 }
100 101
101 } // namespace 102 } // namespace
102 } // namespace test 103 } // namespace test
103 } // namespace crashpad 104 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_module_writer_test.cc ('k') | minidump/minidump_simple_string_dictionary_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698