Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151343002: Web MIDI: make naming convention be consistent (Closed)

Created:
6 years, 10 months ago by Takashi Toyoshima
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, fischman+watch_chromium.org, tfarina, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, markusheintz_, benjhayden+dwatch_chromium.org, wjia+watch_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, yhirano
Visibility:
Public.

Description

Web MIDI: make naming convention be consistent Naming cleanup based on following rules: - MidiFooBar ... use this style to be consistent with chromium - WebMIDIFooBar ... Web API name related things, or names in blink - MIDIFooBar ... APIs and structures defined by each operating systems Other cleanup: - Modify some TODO(crogers) to TODO(toyoshim) - Add some crbug links. - Remove some obsolete UI TODOs related to infobars BUG=none TEST=build for all platforms Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248686

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix mac build #

Patch Set 4 : #

Total comments: 5

Patch Set 5 : rebase #

Patch Set 6 : review boliu #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -545 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 2 3 4 5 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_usages_state_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/permission_queue_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context.h View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context.cc View 1 2 3 4 5 6 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context_factory.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context_factory.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.h View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/midi_dispatcher_host.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/midi_dispatcher_host.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M content/browser/renderer_host/media/midi_host.h View 4 chunks +15 lines, -15 lines 0 comments Download
M content/browser/renderer_host/media/midi_host.cc View 8 chunks +25 lines, -26 lines 0 comments Download
M content/browser/renderer_host/media/midi_host_unittest.cc View 3 chunks +17 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/media/midi_messages.h View 1 chunk +14 lines, -14 lines 0 comments Download
M content/public/browser/browser_context.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/midi_dispatcher.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/midi_dispatcher.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 7 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 10 chunks +37 lines, -37 lines 0 comments Download
M content/renderer/media/renderer_webmidiaccessor_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/renderer_webmidiaccessor_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager.h View 4 chunks +26 lines, -26 lines 0 comments Download
M media/midi/midi_manager.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 2 3 4 5 7 chunks +26 lines, -25 lines 0 comments Download
M media/midi/midi_manager_mac.h View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M media/midi/midi_manager_mac.cc View 1 2 3 11 chunks +24 lines, -24 lines 0 comments Download
M media/midi/midi_manager_usb.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M media/midi/midi_manager_win.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/midi/midi_manager_win.cc View 15 chunks +31 lines, -31 lines 0 comments Download
M media/midi/midi_message_queue.h View 3 chunks +5 lines, -5 lines 0 comments Download
M media/midi/midi_message_queue.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/midi/midi_message_queue_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M media/midi/midi_message_util.h View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_message_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_message_util_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M media/midi/midi_port_info.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/midi/midi_port_info.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/midi/usb_midi_descriptor_parser_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Takashi Toyoshima
Hi owners, This is a large... but trivial CL for renaming. Can you take a ...
6 years, 10 months ago (2014-01-31 13:19:14 UTC) #1
boliu
android_webview lgtm stamp https://codereview.chromium.org/151343002/diff/60001/android_webview/browser/aw_browser_context.cc File android_webview/browser/aw_browser_context.cc (right): https://codereview.chromium.org/151343002/diff/60001/android_webview/browser/aw_browser_context.cc#newcode175 android_webview/browser/aw_browser_context.cc:175: // TODO(crbug.com/339767): Android is not supported ...
6 years, 10 months ago (2014-01-31 15:51:32 UTC) #2
palmer
IPC security LGTM. In general it's better to avoid these rename-only CLs, though. https://codereview.chromium.org/151343002/diff/60001/media/midi/midi_manager_mac.cc File ...
6 years, 10 months ago (2014-01-31 19:40:00 UTC) #3
scherkus (not reviewing)
lgtm https://codereview.chromium.org/151343002/diff/60001/android_webview/browser/aw_browser_context.cc File android_webview/browser/aw_browser_context.cc (right): https://codereview.chromium.org/151343002/diff/60001/android_webview/browser/aw_browser_context.cc#newcode175 android_webview/browser/aw_browser_context.cc:175: // TODO(crbug.com/339767): Android is not supported yet. On ...
6 years, 10 months ago (2014-01-31 20:48:53 UTC) #4
Takashi Toyoshima
Thanks. jochen: content/renderer, and content/test sky: chrome, and content/browser Please take a look at Patch ...
6 years, 10 months ago (2014-02-03 04:24:52 UTC) #5
sky
LGTM
6 years, 10 months ago (2014-02-03 21:19:04 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-03 22:32:15 UTC) #7
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 10 months ago (2014-02-04 01:15:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/151343002/170001
6 years, 10 months ago (2014-02-04 01:17:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 02:20:34 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-04 02:20:35 UTC) #11
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 10 months ago (2014-02-04 03:08:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/151343002/170001
6 years, 10 months ago (2014-02-04 03:08:18 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 06:08:56 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222792
6 years, 10 months ago (2014-02-04 06:08:57 UTC) #15
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 10 months ago (2014-02-04 06:27:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/151343002/170001
6 years, 10 months ago (2014-02-04 06:27:56 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 07:05:52 UTC) #18
Message was sent while issue was closed. 
Change committed as 248686

Powered by Google App Engine
This is Rietveld 408576698