Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: media/midi/midi_message_queue_unittest.cc

Issue 151343002: Web MIDI: make naming convention be consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review boliu #2 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_message_queue.cc ('k') | media/midi/midi_message_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_message_queue_unittest.cc
diff --git a/media/midi/midi_message_queue_unittest.cc b/media/midi/midi_message_queue_unittest.cc
index a00eea6b9e4f0b36ac7fff3c9b15de3f5760af55..3c7122654e7df9bcc45f2fd544e31a6034c1c237 100644
--- a/media/midi/midi_message_queue_unittest.cc
+++ b/media/midi/midi_message_queue_unittest.cc
@@ -28,7 +28,7 @@ const uint8 kBrokenData3[] = { 0xf2, 0x00 };
const uint8 kDataByte0[] = { 0x00 };
template <typename T, size_t N>
-void Add(MIDIMessageQueue* queue, const T(&array)[N]) {
+void Add(MidiMessageQueue* queue, const T(&array)[N]) {
queue->Add(array, N);
}
@@ -54,15 +54,15 @@ template <typename T, size_t N>
#define EXPECT_MESSAGE(expected, actual) \
EXPECT_PRED_FORMAT2(ExpectEqualSequence, expected, actual)
-TEST(MIDIMessageQueueTest, EmptyData) {
- MIDIMessageQueue queue(false);
+TEST(MidiMessageQueueTest, EmptyData) {
+ MidiMessageQueue queue(false);
std::vector<uint8> message;
queue.Get(&message);
EXPECT_TRUE(message.empty());
}
-TEST(MIDIMessageQueueTest, RunningStatusDisabled) {
- MIDIMessageQueue queue(false);
+TEST(MidiMessageQueueTest, RunningStatusDisabled) {
+ MidiMessageQueue queue(false);
Add(&queue, kGMOn);
Add(&queue, kBrokenData1);
Add(&queue, kNoteOnWithRunningStatus);
@@ -94,8 +94,8 @@ TEST(MIDIMessageQueueTest, RunningStatusDisabled) {
EXPECT_TRUE(message.empty());
}
-TEST(MIDIMessageQueueTest, RunningStatusEnabled) {
- MIDIMessageQueue queue(true);
+TEST(MidiMessageQueueTest, RunningStatusEnabled) {
+ MidiMessageQueue queue(true);
Add(&queue, kGMOn);
Add(&queue, kBrokenData1);
Add(&queue, kNoteOnWithRunningStatus);
@@ -139,8 +139,8 @@ TEST(MIDIMessageQueueTest, RunningStatusEnabled) {
<< "Running status must not be applied to real time messages";
}
-TEST(MIDIMessageQueueTest, RunningStatusEnabledWithRealTimeEvent) {
- MIDIMessageQueue queue(true);
+TEST(MidiMessageQueueTest, RunningStatusEnabledWithRealTimeEvent) {
+ MidiMessageQueue queue(true);
const uint8 kNoteOnWithRunningStatusWithkTimingClock[] = {
0x90, 0xf8, 0x3c, 0xf8, 0x7f, 0xf8, 0x3c, 0xf8, 0x7f, 0xf8, 0x3c, 0xf8,
0x7f,
« no previous file with comments | « media/midi/midi_message_queue.cc ('k') | media/midi/midi_message_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698