Clear child's floats when moving from parent with block children to parent with inline children

Clear child's floats when moving from parent with block children to parent with inline children

If a child's children are inline we still want to clear any floats it has if it
is moving from a block to an inline context.

This was an oversight while doing https://codereview.chromium.org/1495033002.

BUG=568744
Committed: https://crrev.com/bff460660c6a1f24141f379c998b4fa774dc6691
Cr-Commit-Position: refs/heads/master@{#365226}

[rhogan, 2015-12-11 13:06:36]

Description was changed from

==========
Clear child's floats when moving from parent with block children to parent with
inline children
BUG=568744
==========

to

==========
Clear child's floats when moving from parent with block children to parent with
inline children

If a child's children are inline we still want to clear any floats it has if it
is moving from a block to an inline context.

This was an oversight while doing https://codereview.chromium.org/1495033002.

BUG=568744
==========

[rhogan, 2015-12-11 13:06:37]

robhogan@gmail.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2015-12-11 14:24:31]

https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html
(right):

https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html:3:
#container {
Is that a tab I see?

https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html:6:
#canvas{
The ID selector #canvas ends up matching two elements. Not so nice. Maybe just
use a "canvas" selector instead of "#canvas"?

https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html:7:
display: table-cell;
display:block would hurt less in my brain.

https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html:24:
// Make the pre element have inline children.
"Block children". That's what you're fixing here, after all. CANVAS is displayed
as a table-cell (or block, if you do what I suggest above).

https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html:26:
// Change the pre element so that it is now inline and folds into an adjacent
anonymous block.
It certainly doesn't become inline. It just becomes out-of-flow, so that it
should fold into an adjacent anonymous block with inline children if it exists.

https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html:29:
document.getElementById("container").style.display = "table";
This triggers a re-attach. display = "none" is also an option, which will only
trigger a detach, which suffices.

[rhogan, 2015-12-11 17:02:34]

On 2015/12/11 at 14:24:31, mstensho wrote:
> 
>
https://codereview.chromium.org/1513303005/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html:29:
document.getElementById("container").style.display = "table";
> This triggers a re-attach. display = "none" is also an option, which will only
trigger a detach, which suffices.

Thanks mstensho - applied your comments.

[mstensho (USE GERRIT), 2015-12-14 10:55:45]

lgtm

[rhogan, 2015-12-15 10:00:38]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2015-12-15 10:00:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513303005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513303005/20001

[commit-bot: I haz the power, 2015-12-15 11:22:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-15 11:24:28]

Description was changed from

==========
Clear child's floats when moving from parent with block children to parent with
inline children

If a child's children are inline we still want to clear any floats it has if it
is moving from a block to an inline context.

This was an oversight while doing https://codereview.chromium.org/1495033002.

BUG=568744
==========

to

==========
Clear child's floats when moving from parent with block children to parent with
inline children

If a child's children are inline we still want to clear any floats it has if it
is moving from a block to an inline context.

This was an oversight while doing https://codereview.chromium.org/1495033002.

BUG=568744

Committed: https://crrev.com/bff460660c6a1f24141f379c998b4fa774dc6691
Cr-Commit-Position: refs/heads/master@{#365226}
==========

[commit-bot: I haz the power, 2015-12-15 11:24:28]

Patchset 2 (id:??) landed as
https://crrev.com/bff460660c6a1f24141f379c998b4fa774dc6691
Cr-Commit-Position: refs/heads/master@{#365226}