third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html - Issue 1513303005: Clear child's floats when moving from parent with block children to parent with inline children

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3.html

Issue 1513303005: Clear child's floats when moving from parent with block children to parent with inline children (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-3-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #container {
	mstensho (USE GERRIT) 2015/12/11 14:24:30 Is that a tab I see? Is that a tab I see?
	4 float: right;

	5 }

	6 #canvas{
	mstensho (USE GERRIT) 2015/12/11 14:24:31 The ID selector #canvas ends up matching two eleme The ID selector #canvas ends up matching two elements. Not so nice. Maybe just use a "canvas" selector instead of "#canvas"?
	7 display: table-cell;
	mstensho (USE GERRIT) 2015/12/11 14:24:31 display:block would hurt less in my brain. display:block would hurt less in my brain.
	8 }

	9 </style>

	10 <li></li>

	11 crbug.com/568744: Ensure an element's floats are cleared when it becomes inline. This test shouldn't crash.

	12 <div id="container">

	13 <canvas id="canvas"></canvas>

	14 </div>

	15 <pre id="pre"></pre>

	16 <script>

	17 if (window.testRunner)

	18 testRunner.dumpAsText();

	19

	20 document.body.offsetTop;

	21 var canvas = document.getElementById("canvas")

	22 var pre = document.getElementById("pre")

	23

	24 // Make the pre element have inline children.
	mstensho (USE GERRIT) 2015/12/11 14:24:31 "Block children". That's what you're fixing here, "Block children". That's what you're fixing here, after all. CANVAS is displayed as a table-cell (or block, if you do what I suggest above).
	25 pre.appendChild(canvas.cloneNode());

	26 // Change the pre element so that it is now inline and folds into an adj acent anonymous block.
	mstensho (USE GERRIT) 2015/12/11 14:24:31 It certainly doesn't become inline. It just become It certainly doesn't become inline. It just becomes out-of-flow, so that it should fold into an adjacent anonymous block with inline children if it exists.
	27 pre.style.position = 'absolute';

	28 // Destroy the float that should no longer be in the pre's float lists.

	29 document.getElementById("container").style.display = "table";
	mstensho (USE GERRIT) 2015/12/11 14:24:30 This triggers a re-attach. display = "none" is als This triggers a re-attach. display = "none" is also an option, which will only trigger a detach, which suffices.
	30 // Re-compute style, but don't layout. (Layout would rebuild float lists and avoid a crash.)

	31 getComputedStyle(pre).color;

	32 // Prompt the canvas to access the float destroyed above if it hasn't be en removed from pre's float lists.

	33 document.body.style.zoom=0.50

	34 </script>

OLD	NEW