pkg/compiler/lib/src/library_loader.dart - Issue 1513263002: Support optional package name arguments to --show-package-warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/library_loader.dart

Issue 1513263002: Support optional package name arguments to --show-package-warnings (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart ('k') | pkg/compiler/lib/src/parser/partial_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/library_loader.dart

diff --git a/pkg/compiler/lib/src/library_loader.dart b/pkg/compiler/lib/src/library_loader.dart

index f0b296b1581b9663c8886a416fb63127667a9264..b37371e84a83dd396be817d2ca2dcb62294de43b 100644

--- a/pkg/compiler/lib/src/library_loader.dart

+++ b/pkg/compiler/lib/src/library_loader.dart

@@ -1078,7 +1078,7 @@ class LibraryDependencyNode {

if (element == null) {

if (combinator.isHide) {

if (library.isPackageLibrary &&

- !reporter.options.showPackageWarnings) {

+ reporter.options.hidePackageWarnings) {

// Only report hide hint on packages if we show warnings on these:

// The hide may be non-empty in some versions of the package, in

// which case you shouldn't remove the combinator.

« no previous file with comments | « pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart ('k') | pkg/compiler/lib/src/parser/partial_elements.dart » ('j') | no next file with comments »