Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: pkg/compiler/lib/src/library_loader.dart

Issue 1513263002: Support optional package name arguments to --show-package-warnings (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.library_loader; 5 library dart2js.library_loader;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'common.dart'; 9 import 'common.dart';
10 import 'common/names.dart' show 10 import 'common/names.dart' show
(...skipping 1060 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 LibraryDependency tag, 1071 LibraryDependency tag,
1072 LibraryElement library) { 1072 LibraryElement library) {
1073 if (tag == null || tag.combinators == null) return; 1073 if (tag == null || tag.combinators == null) return;
1074 for (Combinator combinator in tag.combinators) { 1074 for (Combinator combinator in tag.combinators) {
1075 for (Identifier identifier in combinator.identifiers) { 1075 for (Identifier identifier in combinator.identifiers) {
1076 String name = identifier.source; 1076 String name = identifier.source;
1077 Element element = library.findExported(name); 1077 Element element = library.findExported(name);
1078 if (element == null) { 1078 if (element == null) {
1079 if (combinator.isHide) { 1079 if (combinator.isHide) {
1080 if (library.isPackageLibrary && 1080 if (library.isPackageLibrary &&
1081 !reporter.options.showPackageWarnings) { 1081 reporter.options.hidePackageWarnings) {
1082 // Only report hide hint on packages if we show warnings on these: 1082 // Only report hide hint on packages if we show warnings on these:
1083 // The hide may be non-empty in some versions of the package, in 1083 // The hide may be non-empty in some versions of the package, in
1084 // which case you shouldn't remove the combinator. 1084 // which case you shouldn't remove the combinator.
1085 continue; 1085 continue;
1086 } 1086 }
1087 reporter.reportHintMessage( 1087 reporter.reportHintMessage(
1088 identifier, 1088 identifier,
1089 MessageKind.EMPTY_HIDE, 1089 MessageKind.EMPTY_HIDE,
1090 {'uri': library.canonicalUri, 1090 {'uri': library.canonicalUri,
1091 'name': name}); 1091 'name': name});
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1355 } 1355 }
1356 suffixes.add(const Link<Uri>().prepend(canonicalUri)); 1356 suffixes.add(const Link<Uri>().prepend(canonicalUri));
1357 } 1357 }
1358 suffixChainMap[library] = suffixes; 1358 suffixChainMap[library] = suffixes;
1359 return; 1359 return;
1360 } 1360 }
1361 1361
1362 computeSuffixes(rootLibrary, const Link<Uri>()); 1362 computeSuffixes(rootLibrary, const Link<Uri>());
1363 } 1363 }
1364 } 1364 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart ('k') | pkg/compiler/lib/src/parser/partial_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698