src/a64/lithium-a64.cc - Issue 151323002: A64: Fix assertion in DoMathMinMax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/lithium-a64.cc

Issue 151323002: A64: Fix assertion in DoMathMinMax. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/a64/lithium-a64.cc

diff --git a/src/a64/lithium-a64.cc b/src/a64/lithium-a64.cc

index a2fd9fc329ddd20567eb10b84e3586bccb1a6f2d..8fd59c779d0ae3c7123ce634da8b27f461245ca9 100644

--- a/src/a64/lithium-a64.cc

+++ b/src/a64/lithium-a64.cc

@@ -1824,8 +1824,8 @@ LInstruction* LChunkBuilder::DoMathMinMax(HMathMinMax* instr) {

LOperand* left = NULL;

LOperand* right = NULL;

if (instr->representation().IsSmiOrInteger32()) {

- ASSERT(instr->left()->representation().IsInteger32());

- ASSERT(instr->right()->representation().IsInteger32());

+ ASSERT(instr->left()->representation().Equals(instr->representation()));

+ ASSERT(instr->right()->representation().Equals(instr->representation()));

left = UseRegisterAtStart(instr->BetterLeftOperand());

right = UseRegisterOrConstantAtStart(instr->BetterRightOperand());

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »