Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: src/a64/lithium-a64.cc

Issue 151323002: A64: Fix assertion in DoMathMinMax. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
1817 LOperand* remainder = TempRegister(); 1817 LOperand* remainder = TempRegister();
1818 return AssignEnvironment(DefineAsRegister( 1818 return AssignEnvironment(DefineAsRegister(
1819 new(zone()) LMathFloorOfDiv(dividend, divisor, remainder))); 1819 new(zone()) LMathFloorOfDiv(dividend, divisor, remainder)));
1820 } 1820 }
1821 1821
1822 1822
1823 LInstruction* LChunkBuilder::DoMathMinMax(HMathMinMax* instr) { 1823 LInstruction* LChunkBuilder::DoMathMinMax(HMathMinMax* instr) {
1824 LOperand* left = NULL; 1824 LOperand* left = NULL;
1825 LOperand* right = NULL; 1825 LOperand* right = NULL;
1826 if (instr->representation().IsSmiOrInteger32()) { 1826 if (instr->representation().IsSmiOrInteger32()) {
1827 ASSERT(instr->left()->representation().IsInteger32()); 1827 ASSERT(instr->left()->representation().Equals(instr->representation()));
1828 ASSERT(instr->right()->representation().IsInteger32()); 1828 ASSERT(instr->right()->representation().Equals(instr->representation()));
1829 left = UseRegisterAtStart(instr->BetterLeftOperand()); 1829 left = UseRegisterAtStart(instr->BetterLeftOperand());
1830 right = UseRegisterOrConstantAtStart(instr->BetterRightOperand()); 1830 right = UseRegisterOrConstantAtStart(instr->BetterRightOperand());
1831 } else { 1831 } else {
1832 ASSERT(instr->representation().IsDouble()); 1832 ASSERT(instr->representation().IsDouble());
1833 ASSERT(instr->left()->representation().IsDouble()); 1833 ASSERT(instr->left()->representation().IsDouble());
1834 ASSERT(instr->right()->representation().IsDouble()); 1834 ASSERT(instr->right()->representation().IsDouble());
1835 left = UseRegisterAtStart(instr->left()); 1835 left = UseRegisterAtStart(instr->left());
1836 right = UseRegisterAtStart(instr->right()); 1836 right = UseRegisterAtStart(instr->right());
1837 } 1837 }
1838 return DefineAsRegister(new(zone()) LMathMinMax(left, right)); 1838 return DefineAsRegister(new(zone()) LMathMinMax(left, right));
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
2570 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) { 2570 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
2571 LOperand* receiver = UseRegister(instr->receiver()); 2571 LOperand* receiver = UseRegister(instr->receiver());
2572 LOperand* function = UseRegisterAtStart(instr->function()); 2572 LOperand* function = UseRegisterAtStart(instr->function());
2573 LOperand* temp = TempRegister(); 2573 LOperand* temp = TempRegister();
2574 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function, temp); 2574 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function, temp);
2575 return AssignEnvironment(DefineAsRegister(result)); 2575 return AssignEnvironment(DefineAsRegister(result));
2576 } 2576 }
2577 2577
2578 2578
2579 } } // namespace v8::internal 2579 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698