[debugger] debug-evaluate should not not modify local values.

[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}

Committed: https://crrev.com/abe2feb08157f1a7a4597536e8bc06b07034c5a6
Cr-Commit-Position: refs/heads/master@{#32857}

[Yang, 2015-12-10 13:12:48]

Description was changed from

==========
[debugger] debug-evaluate should not not modify local values.

R=mstarzinger@chromium.org, rossberg@chromium.org
==========

to

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org
==========

[Yang, 2015-12-10 13:13:12]

On 2015/12/10 13:12:48, Yang wrote:
> Description was changed from
> 
> ==========
> [debugger] debug-evaluate should not not modify local values.
> 
> mailto:R=mstarzinger@chromium.org, mailto:rossberg@chromium.org
> ==========
> 
> to
> 
> ==========
> [debugger] debug-evaluate should not not modify local values.
> 
> Debug evaluate no longer writes back changes to the replicated
> context chain to the original after execution. Changes to the
> global object or script contexts still stick. Calling functions
> that bind to the original context chain also have their expected
> side effects.
> 
> As far as I can tell, DevTools is not interested in modifying
> local variable values. Modifying global variable values still
> works as expected. However, I have not yet removed the old
> implementation, but merely keep it behind a flag.
> 
> mailto:R=mstarzinger@chromium.org, mailto:rossberg@chromium.org
> ==========

Please take a look.
This CL is dependent on https://codereview.chromium.org/1500933002/

[Michael Starzinger, 2015-12-14 12:11:23]

LGTM if new semantics still accommodate how our embedders (e.g. DevTools) use
the debugger interface, I don't have enough information to judge that.

https://codereview.chromium.org/1513183003/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1513183003/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:556: DEFINE_BOOL(debug_eval_readonly_locals, true,
nit/suggestion: There already is a section for "debug.cc" a couple of lines
further down, would it make sense to move this flag down? WDYT?

[Yang, 2015-12-14 14:20:00]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-12-14 14:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1513183003/#ps20001
(title: "addressed comments.")

[commit-bot: I haz the power, 2015-12-14 14:20:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513183003/20001

[commit-bot: I haz the power, 2015-12-14 14:53:45]

Description was changed from

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org
==========

to

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org
==========

[commit-bot: I haz the power, 2015-12-14 14:53:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-14 14:54:33]

Description was changed from

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org
==========

to

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}
==========

[commit-bot: I haz the power, 2015-12-14 14:54:33]

Patchset 2 (id:??) landed as
https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}

[Michael Achenbach, 2015-12-14 17:18:44]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1526553003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Layout test changes..

[Yang, 2015-12-15 06:08:05]

Description was changed from

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}
==========

to

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}
==========

[Yang, 2015-12-15 09:52:52]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-12-15 09:52:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513183003/20001

[commit-bot: I haz the power, 2015-12-15 09:53:59]

Description was changed from

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}
==========

to

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}
==========

[commit-bot: I haz the power, 2015-12-15 09:54:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-15 09:54:49]

Description was changed from

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}
==========

to

==========
[debugger] debug-evaluate should not not modify local values.

Debug evaluate no longer writes back changes to the replicated
context chain to the original after execution. Changes to the
global object or script contexts still stick. Calling functions
that bind to the original context chain also have their expected
side effects.

As far as I can tell, DevTools is not interested in modifying
local variable values. Modifying global variable values still
works as expected. However, I have not yet removed the old
implementation, but merely keep it behind a flag.

R=mstarzinger@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
Cr-Commit-Position: refs/heads/master@{#32841}

Committed: https://crrev.com/abe2feb08157f1a7a4597536e8bc06b07034c5a6
Cr-Commit-Position: refs/heads/master@{#32857}
==========

[commit-bot: I haz the power, 2015-12-15 09:54:50]

Patchset 2 (id:??) landed as
https://crrev.com/abe2feb08157f1a7a4597536e8bc06b07034c5a6
Cr-Commit-Position: refs/heads/master@{#32857}