Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: test/mjsunit/debug-evaluate-locals-capturing.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/debug-evaluate-locals.js ('k') | test/mjsunit/debug-evaluate-modify-catch-block-scope.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/debug-evaluate-locals-capturing.js
diff --git a/test/mjsunit/debug-evaluate-locals-capturing.js b/test/mjsunit/debug-evaluate-locals-capturing.js
index 77bdfc6294b11f2c96fbcefcf3205f224f14181f..6d65861fc7b1628a1887b103fd2ef4d8c46d5d4d 100644
--- a/test/mjsunit/debug-evaluate-locals-capturing.js
+++ b/test/mjsunit/debug-evaluate-locals-capturing.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --expose-debug-as debug
+// Flags: --expose-debug-as debug --debug-eval-readonly-locals
Debug = debug.Debug
var exception = null;
@@ -15,8 +15,8 @@ function listener(event, exec_state, event_data, data) {
if (event == Debug.DebugEvent.Break) {
var frameMirror = exec_state.frame(0);
- f = frameMirror.evaluate('f = function() { i = 5; }, f(), f').value();
- print(f);
+ var i = frameMirror.evaluate('f = function() { i = 5; }, f(), i').value();
+ assertEquals(5, i);
}
} catch(e) {
exception = e;
@@ -35,7 +35,7 @@ Debug.setListener(listener);
} catch (e) {
assertEquals(0, i);
debugger;
- assertEquals(5, i);
+ assertEquals(0, i);
}
}());
« no previous file with comments | « test/mjsunit/debug-evaluate-locals.js ('k') | test/mjsunit/debug-evaluate-modify-catch-block-scope.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698