Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4289)

Unified Diff: chrome/installer/util/logging_installer_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/installer_state_unittest.cc ('k') | chrome/installer/util/lzma_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/logging_installer_unittest.cc
diff --git a/chrome/installer/util/logging_installer_unittest.cc b/chrome/installer/util/logging_installer_unittest.cc
index 06b959a8b9c329e01fdb5b53a40de107ffa01b5c..bbe085de59bf9dd1c269bae2e46052c1fa258241 100644
--- a/chrome/installer/util/logging_installer_unittest.cc
+++ b/chrome/installer/util/logging_installer_unittest.cc
@@ -19,7 +19,7 @@ TEST(LoggingInstallerTest, TestTruncate) {
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath temp_file = temp_dir.path().Append(L"temp");
- EXPECT_EQ(test_data.size(),
+ EXPECT_EQ(static_cast<int>(test_data.size()),
base::WriteFile(temp_file, &test_data[0],
static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
@@ -45,7 +45,7 @@ TEST(LoggingInstallerTest, TestTruncationNotNeeded) {
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath temp_file = temp_dir.path().Append(L"temp");
- EXPECT_EQ(test_data.size(),
+ EXPECT_EQ(static_cast<int>(test_data.size()),
base::WriteFile(temp_file, &test_data[0],
static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
@@ -68,7 +68,7 @@ TEST(LoggingInstallerTest, TestInUseNeedsTruncation) {
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath temp_file = temp_dir.path().Append(L"temp");
- EXPECT_EQ(test_data.size(),
+ EXPECT_EQ(static_cast<int>(test_data.size()),
base::WriteFile(temp_file, &test_data[0],
static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
@@ -97,7 +97,7 @@ TEST(LoggingInstallerTest, TestMoveFailsNeedsTruncation) {
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath temp_file = temp_dir.path().Append(L"temp");
- EXPECT_EQ(test_data.size(),
+ EXPECT_EQ(static_cast<int>(test_data.size()),
base::WriteFile(temp_file, &test_data[0],
static_cast<int>(test_data.size())));
ASSERT_TRUE(base::PathExists(temp_file));
« no previous file with comments | « chrome/installer/util/installer_state_unittest.cc ('k') | chrome/installer/util/lzma_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698