chrome/utility/importer/edge_database_reader_unittest_win.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/edge_database_reader_unittest_win.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/in_memory_url_index_unittest.cc ('K') | « chrome/installer/util/wmi_unittest.cc ('k') | chrome_elf/blacklist/test/blacklist_test.cc » ('j') | device/hid/hid_service_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/edge_database_reader_unittest_win.cc

diff --git a/chrome/utility/importer/edge_database_reader_unittest_win.cc b/chrome/utility/importer/edge_database_reader_unittest_win.cc

index d0a0b7768e03bcfd67fb8bf75e6f6436da6f7878..c902bcbad9625f9b0419901c1c1bc4058b5df2ce 100644

--- a/chrome/utility/importer/edge_database_reader_unittest_win.cc

+++ b/chrome/utility/importer/edge_database_reader_unittest_win.cc

@@ -194,7 +194,7 @@ TEST_F(EdgeDatabaseReaderTest, OpenTableAndReadDataDatabaseTest) {

uint32_t uint_col_value = 0;

EXPECT_TRUE(table_enum->RetrieveColumn(L"UIntCol", &uint_col_value));

- EXPECT_EQ(uint_col_value, row_count);

+ EXPECT_EQ(uint_col_value, static_cast<uint32_t>(row_count));

int64_t longlong_col_value = 0;

EXPECT_TRUE(

@@ -381,15 +381,15 @@ TEST_F(EdgeDatabaseReaderTest, CheckNullColumnDatabaseTest) {

// back.

int32_t int_col_value = 1;

EXPECT_TRUE(table_enum->RetrieveColumn(L"IntCol", &int_col_value));

- EXPECT_EQ(int_col_value, 0);

+ EXPECT_EQ(0, int_col_value);

uint32_t uint_col_value = 1;

EXPECT_TRUE(table_enum->RetrieveColumn(L"UIntCol", &uint_col_value));

- EXPECT_EQ(uint_col_value, 0);

+ EXPECT_EQ(0u, uint_col_value);

int64_t longlong_col_value = 1;

EXPECT_TRUE(table_enum->RetrieveColumn(L"LongLongCol", &longlong_col_value));

- EXPECT_EQ(longlong_col_value, 0);

+ EXPECT_EQ(0, longlong_col_value);

GUID guid_col_value = {};

GUID expected_guid_col_value = {};