Chromium Code Reviews| Index: chrome/browser/autocomplete/in_memory_url_index_unittest.cc |
| diff --git a/chrome/browser/autocomplete/in_memory_url_index_unittest.cc b/chrome/browser/autocomplete/in_memory_url_index_unittest.cc |
| index f350b44f4277a786656aec0deb9d212e46e8fb35..f84cd281b0d855c1a00bf5209c4bd09e63dabaf9 100644 |
| --- a/chrome/browser/autocomplete/in_memory_url_index_unittest.cc |
| +++ b/chrome/browser/autocomplete/in_memory_url_index_unittest.cc |
| @@ -1032,9 +1032,9 @@ TEST_F(InMemoryURLIndexTest, ReadVisitsFromHistory) { |
| { |
| const VisitInfoVector& visits = entry->second.visits; |
| EXPECT_EQ(3u, visits.size()); |
|
Lei Zhang
2015/12/09 22:17:15
ASSERT_EQ(), ditto below, sigh.
Nico
2015/12/09 22:22:35
Done.
|
| - EXPECT_EQ(0u, visits[0].second); |
| - EXPECT_EQ(1u, visits[1].second); |
| - EXPECT_EQ(0u, visits[2].second); |
| + EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[0].second); |
|
Lei Zhang
2015/12/09 22:17:15
Maybe just use the enum values?
Nico
2015/12/09 22:22:35
I figured this uses literal ints to also test that
|
| + EXPECT_EQ(static_cast<ui::PageTransition>(1u), visits[1].second); |
| + EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[2].second); |
| } |
| // Ditto but for URL with id 35. |
| @@ -1043,8 +1043,8 @@ TEST_F(InMemoryURLIndexTest, ReadVisitsFromHistory) { |
| { |
| const VisitInfoVector& visits = entry->second.visits; |
| EXPECT_EQ(2u, visits.size()); |
| - EXPECT_EQ(1u, visits[0].second); |
| - EXPECT_EQ(1u, visits[1].second); |
| + EXPECT_EQ(static_cast<ui::PageTransition>(1u), visits[0].second); |
| + EXPECT_EQ(static_cast<ui::PageTransition>(1u), visits[1].second); |
| } |
| // The URL with id 32 has many visits listed in the database, but we |
| @@ -1055,7 +1055,7 @@ TEST_F(InMemoryURLIndexTest, ReadVisitsFromHistory) { |
| const VisitInfoVector& visits = entry->second.visits; |
| EXPECT_EQ(10u, visits.size()); |
| for (size_t i = 0; i < visits.size(); ++i) |
| - EXPECT_EQ(0u, visits[i].second); |
| + EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[i].second); |
| } |
| } |