chrome/installer/util/logging_installer_unittest.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/logging_installer_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/in_memory_url_index_unittest.cc ('K') | « chrome/installer/util/installer_state_unittest.cc ('k') | chrome/installer/util/lzma_util_unittest.cc » ('j') | device/hid/hid_service_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/logging_installer_unittest.cc

diff --git a/chrome/installer/util/logging_installer_unittest.cc b/chrome/installer/util/logging_installer_unittest.cc

index 06b959a8b9c329e01fdb5b53a40de107ffa01b5c..bbe085de59bf9dd1c269bae2e46052c1fa258241 100644

--- a/chrome/installer/util/logging_installer_unittest.cc

+++ b/chrome/installer/util/logging_installer_unittest.cc

@@ -19,7 +19,7 @@ TEST(LoggingInstallerTest, TestTruncate) {

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

base::FilePath temp_file = temp_dir.path().Append(L"temp");

- EXPECT_EQ(test_data.size(),

+ EXPECT_EQ(static_cast<int>(test_data.size()),

base::WriteFile(temp_file, &test_data[0],

static_cast<int>(test_data.size())));

ASSERT_TRUE(base::PathExists(temp_file));

@@ -45,7 +45,7 @@ TEST(LoggingInstallerTest, TestTruncationNotNeeded) {

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

base::FilePath temp_file = temp_dir.path().Append(L"temp");

- EXPECT_EQ(test_data.size(),

+ EXPECT_EQ(static_cast<int>(test_data.size()),

base::WriteFile(temp_file, &test_data[0],

static_cast<int>(test_data.size())));

ASSERT_TRUE(base::PathExists(temp_file));

@@ -68,7 +68,7 @@ TEST(LoggingInstallerTest, TestInUseNeedsTruncation) {

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

base::FilePath temp_file = temp_dir.path().Append(L"temp");

- EXPECT_EQ(test_data.size(),

+ EXPECT_EQ(static_cast<int>(test_data.size()),

base::WriteFile(temp_file, &test_data[0],

static_cast<int>(test_data.size())));

ASSERT_TRUE(base::PathExists(temp_file));

@@ -97,7 +97,7 @@ TEST(LoggingInstallerTest, TestMoveFailsNeedsTruncation) {

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

base::FilePath temp_file = temp_dir.path().Append(L"temp");

- EXPECT_EQ(test_data.size(),

+ EXPECT_EQ(static_cast<int>(test_data.size()),

base::WriteFile(temp_file, &test_data[0],

static_cast<int>(test_data.size())));

ASSERT_TRUE(base::PathExists(temp_file));