Lock '--disable-web-security' to '--user-data-dir'

Lock '--disable-web-security' to '--user-data-dir'

BUG=327804
Committed: https://crrev.com/a1f7749bb0d8e5934d6b0c3adafbf0cb47cf7815
Cr-Commit-Position: refs/heads/master@{#366963}

[Mike West, 2015-12-09 09:12:29]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 09:14:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512843002/1

[Mike West, 2015-12-09 09:49:36]

The CQ bit was unchecked by mkwst@chromium.org

[Mike West, 2015-12-09 12:37:54]

mkwst@chromium.org changed reviewers:
+ hiroshige@chromium.org, jochen@chromium.org

[Mike West, 2015-12-09 12:37:55]

WDYT, Jochen?

+hiroshige@: I don't think I can land this until you migrate the perf tests off
of `--disable-web-security`. No real rush, but I'd like to make the 49 branch
point if possible. :)

https://codereview.chromium.org/1512843002/diff/1/chrome/browser/chrome_conte...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/1512843002/diff/1/chrome/browser/chrome_conte...
chrome/browser/chrome_content_browser_client.cc:2274: VLOG(1) << "Web security
may only be disabled if '--user-data-dir' is "
Maybe `LOG(ERROR)`?

[jochen (gone - plz use gerrit), 2015-12-09 15:42:12]

lgtm

[hiroshige, 2015-12-14 09:28:46]

> +hiroshige@: I don't think I can land this until you migrate the perf tests
off
> of `--disable-web-security`. No real rush, but I'd like to make the 49 branch
> point if possible. :)
Started, created draft CLs:
https://code.google.com/p/chromium/issues/detail?id=567533

[hiroshige, 2015-12-28 05:01:54]

On 2015/12/14 09:28:46, hiroshige wrote:
> > +hiroshige@: I don't think I can land this until you migrate the perf tests
> off of `--disable-web-security`
Done.

[Mike West, 2015-12-28 07:54:19]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-12-28 07:54:19]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1512843002/#ps20001
(title: "Error.")

[commit-bot: I haz the power, 2015-12-28 07:54:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512843002/20001

[commit-bot: I haz the power, 2015-12-28 09:29:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-28 09:29:55]

Description was changed from

==========
Lock '--disable-web-security' to '--user-data-dir'

BUG=327804
==========

to

==========
Lock '--disable-web-security' to '--user-data-dir'

BUG=327804

Committed: https://crrev.com/a1f7749bb0d8e5934d6b0c3adafbf0cb47cf7815
Cr-Commit-Position: refs/heads/master@{#366963}
==========

[commit-bot: I haz the power, 2015-12-28 09:29:59]

Patchset 2 (id:??) landed as
https://crrev.com/a1f7749bb0d8e5934d6b0c3adafbf0cb47cf7815
Cr-Commit-Position: refs/heads/master@{#366963}

[Mike West, 2015-12-28 10:22:53]

On 2015/12/28 at 09:29:59, commit-bot wrote:
> Patchset 2 (id:??) landed as
https://crrev.com/a1f7749bb0d8e5934d6b0c3adafbf0cb47cf7815
> Cr-Commit-Position: refs/heads/master@{#366963}

Thank you, @hiroshige!