Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1512803002: Flip linux blink bots to GN. (Closed)

Created:
5 years ago by Dirk Pranke
Modified:
5 years ago
CC:
chromium-reviews, ojan, peria
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_blink_bots_to_mb_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip linux blink bots to GN. This flips the regular bots, leak bots, and oilpan bots to GN, but not the ASAN and MSAN bots. R=haraken@chromium.org, phajdan.jr@chromium.org BUG=432959 Committed: https://crrev.com/f6bce52dc0ec0f84660aa4e62906b63366e33805 Cr-Commit-Position: refs/heads/master@{#364236}

Patch Set 1 #

Patch Set 2 : merge to HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M tools/mb/mb_config.pyl View 1 4 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dirk Pranke
Please take a look. This patch depends on https://codereview.chromium.org/1461923003/ having landed first, and should probably ...
5 years ago (2015-12-09 03:22:30 UTC) #1
haraken
LGTM but Pawel should confirm.
5 years ago (2015-12-09 03:26:20 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years ago (2015-12-09 11:03:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512803002/20001
5 years ago (2015-12-09 21:27:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 00:51:57 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f6bce52dc0ec0f84660aa4e62906b63366e33805 Cr-Commit-Position: refs/heads/master@{#364236}
5 years ago (2015-12-10 00:52:57 UTC) #9
Nico
5 years ago (2015-12-10 15:15:22 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1515843003/ by thakis@chromium.org.

The reason for reverting is: Looks like this broke linux_blink_rel, see
http://crbug.com/568582.

Powered by Google App Engine
This is Rietveld 408576698