core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 1512763013: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 1512763013: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index 0bf044101c313563cb1a957c8180775e76ef7297..fbe6faa47100a04a744ec54ed6431d12d5f17dcf 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -349,7 +349,7 @@ CPDF_Stream* CPDF_StreamParser::ReadInlineStream(CPDF_Document* pDoc,

FX_DWORD width = pDict->GetInteger("Width");

FX_DWORD height = pDict->GetInteger("Height");

FX_DWORD OrigSize = 0;

- if (pCSObj != NULL) {

+ if (pCSObj) {

FX_DWORD bpc = pDict->GetInteger("BitsPerComponent");

FX_DWORD nComponents = 1;

CPDF_ColorSpace* pCS = pDoc->LoadColorSpace(pCSObj);