core/src/fpdfapi/fpdf_font/ttgsubtable.h - Issue 1512763013: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/ttgsubtable.h

Issue 1512763013: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/ttgsubtable.h

diff --git a/core/src/fpdfapi/fpdf_font/ttgsubtable.h b/core/src/fpdfapi/fpdf_font/ttgsubtable.h

index e3c996565460789a204d6844e03785a0f8c03fdf..605d25fd579dd1adf3c92f0657a32663df870f4d 100644

--- a/core/src/fpdfapi/fpdf_font/ttgsubtable.h

+++ b/core/src/fpdfapi/fpdf_font/ttgsubtable.h

@@ -277,10 +277,9 @@ class CFX_CTTGSUBTable {

TLookup()

: LookupType(0), LookupFlag(0), SubTableCount(0), SubTable(NULL) {}

~TLookup() {

- if (SubTableCount > 0 && SubTable != NULL) {

- for (int i = 0; i < SubTableCount; i++) {

+ if (SubTable) {

+ for (int i = 0; i < SubTableCount; ++i)

delete SubTable[i];

- }

delete[] SubTable;

}