Remove uniform color for GrDistanceFieldGeoProc

Remove uniform color for GrDistanceFieldGeoProc

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/53f26aa045d58feb9f2114f53629024bffe52dea

[joshualitt, 2015-12-08 21:49:59]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, jvanverth@google.com

[joshualitt, 2015-12-08 21:50:00]

ptal

[bsalomon, 2015-12-09 02:09:06]

Is there a place where we can change something such that DF paths of different
colors can batch? Or were we missing a check before?

[bsalomon, 2015-12-09 02:10:05]

https://codereview.chromium.org/1512533003/diff/1/src/gpu/batches/GrAADistanc...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1512533003/diff/1/src/gpu/batches/GrAADistanc...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:509: // maybe upload color via
attribute
To answer my own question, we should delete this.

[jvanverth1, 2015-12-09 14:25:11]

On 2015/12/09 02:10:05, bsalomon wrote:
>
https://codereview.chromium.org/1512533003/diff/1/src/gpu/batches/GrAADistanc...
> File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):
> 
>
https://codereview.chromium.org/1512533003/diff/1/src/gpu/batches/GrAADistanc...
> src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:509: // maybe upload color
via
> attribute
> To answer my own question, we should delete this.

As a further answer to your question, we still can't batch because there's a
uniform that controls the gamma "distance", which varies with color. It might be
possible to compute the function in the shader, but I'll have to look into it.

[joshualitt, 2015-12-09 14:40:14]

feedback inc

[jvanverth1, 2015-12-09 15:01:06]

LGTM + nit

https://codereview.chromium.org/1512533003/diff/20001/src/gpu/effects/GrDista...
File src/gpu/effects/GrDistanceFieldGeoProc.h (right):

https://codereview.chromium.org/1512533003/diff/20001/src/gpu/effects/GrDista...
src/gpu/effects/GrDistanceFieldGeoProc.h:26: kInvalid_DistanceFieldEffectFlag   
= 0x20,   // invalid state (for initialization)
Nit: I'd rather leave this as 0x80, just so we have room to add flags if needed.

[joshualitt, 2015-12-10 14:22:45]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-12-10 14:22:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512533003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512533003/20001

[commit-bot: I haz the power, 2015-12-10 14:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 14:25:53]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[joshualitt, 2015-12-10 15:17:38]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-12-10 15:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1512533003/#ps40001
(title: "mac warnings")

[commit-bot: I haz the power, 2015-12-10 15:17:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512533003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512533003/40001

[commit-bot: I haz the power, 2015-12-10 15:29:57]

Description was changed from

==========
Remove uniform color for GrDistanceFieldGeoProc

BUG=skia:
==========

to

==========
Remove uniform color for GrDistanceFieldGeoProc

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/53f26aa045d58feb9f2114f53629024bffe52dea
==========

[commit-bot: I haz the power, 2015-12-10 15:29:58]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/53f26aa045d58feb9f2114f53629024bffe52dea