Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1512303002: dart2js cps: Add instruction for bounds checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index 6c7469ee96ce2a25cbc2a9316332ec1402191106..e19b23e4f15a3dc9b9147f0ad73fde92c29dd678 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -389,6 +389,17 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
String value = formatReference(node.value);
return 'Refinement $value ${node.refineType}';
}
+
+ visitBoundsCheck(cps_ir.BoundsCheck node) {
+ String object = formatReference(node.object);
+ String index = node.index == null
+ ? 'no-index'
+ : formatReference(node.index);
+ String length = node.length == null
+ ? 'no-length'
+ : formatReference(node.length);
+ return 'BoundsCheck $object $index $length ${node.checkString}';
+ }
}
/**
@@ -671,4 +682,8 @@ class BlockCollector implements cps_ir.Visitor {
visitRefinement(cps_ir.Refinement node) {
unexpectedNode(node);
}
+
+ visitBoundsCheck(cps_ir.BoundsCheck node) {
+ unexpectedNode(node);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698