Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1512303002: dart2js cps: Add instruction for bounds checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
index 12262e13491f56cc66518585fcd9e5ed1ff3a428..3f5e7c2f837100410959a597d33b87272fe739d5 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
@@ -33,6 +33,10 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
return decorator(r, namer.getName(r.definition));
}
+ String optionalAccess(Reference<Definition> reference) {
+ return reference == null ? '()' : '(${access(reference)})';
+ }
+
String visitParameter(Parameter node) {
return namer.nameParameter(node);
}
@@ -360,6 +364,13 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
String value = access(node.value);
return '(Refinement $value ${node.type})';
}
+
+ String visitBoundsCheck(BoundsCheck node) {
+ String object = access(node.object);
+ String index = optionalAccess(node.index);
+ String length = optionalAccess(node.length);
+ return '(BoundsCheck $object $index $length ${node.checkString})';
+ }
}
class ConstantStringifier extends ConstantValueVisitor<String, Null> {

Powered by Google App Engine
This is Rietveld 408576698