Issue 1512203003: Merge to XFA: Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1512203003: Merge to XFA: Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam(). (Closed)

Created:
5 years ago by Lei Zhang

Modified:
5 years ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam(). TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1507043004 . (cherry picked from commit d9324d8f7345d4546c06c4a9d6cd497b0f7f3ad2) Committed: https://pdfium.googlesource.com/pdfium/+/36a9d086bc8a89d699461b3a03c56745ceae98c3

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -60 lines)			Patch
M	core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/pageint.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	3 chunks	+49 lines, -55 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/render_int.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

Lei Zhang

5 years ago (2015-12-10 08:18:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
36a9d086bc8a89d699461b3a03c56745ceae98c3 (presubmit successful).