Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam().

Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam().

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/d9324d8f7345d4546c06c4a9d6cd497b0f7f3ad2

[Lei Zhang, 2015-12-09 02:01:49]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-12-09 19:27:26]

lgtm

https://codereview.chromium.org/1507043004/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/1507043004/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:951: switch (m_bpc) {
nit: not sure this is an improvement.  Maybe we need inline helper function
IsAllowedBPCValue(bpd) { return bpc == 1 || bpc ==2 || ... }
and here
if (!IsAllowedBPCValue())
  m_pbp = 0;

or some such.  Clever folks might realize that they are all powers of two and
write bpc > 0 && bpc <= 16 && !(bpc & (bpc - 1)) but that is confusing.

[Lei Zhang, 2015-12-10 08:02:32]

https://codereview.chromium.org/1507043004/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/1507043004/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:951: switch (m_bpc) {
On 2015/12/09 19:27:26, Tom Sepez wrote:
> nit: not sure this is an improvement.  Maybe we need inline helper function
> IsAllowedBPCValue(bpd) { return bpc == 1 || bpc ==2 || ... }
> and here
> if (!IsAllowedBPCValue())
>   m_pbp = 0;
> 
> or some such.  Clever folks might realize that they are all powers of two and
> write bpc > 0 && bpc <= 16 && !(bpc & (bpc - 1)) but that is confusing.

Done.

[Lei Zhang, 2015-12-10 08:04:31]

Description was changed from

==========
Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam().
==========

to

==========
Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam().

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/d9324d8f7345d4546c06c4a9d6cd497b0f7f...
==========

[Lei Zhang, 2015-12-10 08:04:32]

Committed patchset #4 (id:60001) manually as
d9324d8f7345d4546c06c4a9d6cd497b0f7f3ad2 (presubmit successful).