Silence libpng warnings in SkImageDecoder

Silence libpng warnings in SkImageDecoder

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7596683275723c6c4f4c1af7772127621d349e5c

[msarett, 2015-12-09 19:15:49]

Patchset #1 (id:1) has been deleted

[msarett, 2015-12-09 19:16:29]

msarett@google.com changed reviewers:
+ caryclark@google.com, scroggo@google.com

[msarett, 2015-12-09 19:16:29]

Turns out the messages were coming from SkImageDecoder.

[scroggo, 2015-12-09 19:20:24]

https://codereview.chromium.org/1512043002/diff/20001/src/images/SkImageDecod...
File src/images/SkImageDecoder_libpng.cpp (right):

https://codereview.chromium.org/1512043002/diff/20001/src/images/SkImageDecod...
src/images/SkImageDecoder_libpng.cpp:40: #if defined(SK_PRINT_CODEC_MESSAGES)
Does this file include SkCodecPriv?

Given that we're moving away from this anyway, it might make sense to just never
default to true (== suppress).

[msarett, 2015-12-09 19:23:41]

https://codereview.chromium.org/1512043002/diff/20001/src/images/SkImageDecod...
File src/images/SkImageDecoder_libpng.cpp (right):

https://codereview.chromium.org/1512043002/diff/20001/src/images/SkImageDecod...
src/images/SkImageDecoder_libpng.cpp:40: #if defined(SK_PRINT_CODEC_MESSAGES)
On 2015/12/09 19:20:24, scroggo wrote:
> Does this file include SkCodecPriv?
> 

No.  It only needs SkCodecPriv if we want to use SkCodecPrintf.

> Given that we're moving away from this anyway, it might make sense to just
never
> default to true (== suppress).

sgtm

[scroggo, 2015-12-09 19:57:56]

On 2015/12/09 19:23:41, msarett wrote:
>
https://codereview.chromium.org/1512043002/diff/20001/src/images/SkImageDecod...
> File src/images/SkImageDecoder_libpng.cpp (right):
> 
>
https://codereview.chromium.org/1512043002/diff/20001/src/images/SkImageDecod...
> src/images/SkImageDecoder_libpng.cpp:40: #if defined(SK_PRINT_CODEC_MESSAGES)
> On 2015/12/09 19:20:24, scroggo wrote:
> > Does this file include SkCodecPriv?
> > 
> 
> No.  It only needs SkCodecPriv if we want to use SkCodecPrintf.
> 
> > Given that we're moving away from this anyway, it might make sense to just
> never
> > default to true (== suppress).
> 
> sgtm

Oh, right. LGTM

[msarett, 2015-12-09 19:58:25]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2015-12-09 19:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512043002/40001

[commit-bot: I haz the power, 2015-12-09 20:12:58]

Description was changed from

==========
Silence libpng warnings in SkImageDecoder

BUG=skia:
==========

to

==========
Silence libpng warnings in SkImageDecoder

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/7596683275723c6c4f4c1af7772127621d349e5c
==========

[commit-bot: I haz the power, 2015-12-09 20:12:58]

Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/7596683275723c6c4f4c1af7772127621d349e5c