Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1511963002: Subzero: Add a proper default for --pnacl-bin-path . (Closed)

Created:
5 years ago by Jim Stichnoth
Modified:
5 years ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add a proper default for --pnacl-bin-path . Defining this argument as "required=False, default=None" means it's not really optional. It's possible to provide a reasonable default like in e.g. szbuild.py. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=79fe490f541654fc6faa3d038305681813132a55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pydir/run-pnacl-sz.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
5 years ago (2015-12-09 14:23:57 UTC) #3
John
lgtm
5 years ago (2015-12-09 15:10:55 UTC) #4
Jim Stichnoth
5 years ago (2015-12-10 19:08:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
79fe490f541654fc6faa3d038305681813132a55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698