Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: pydir/run-pnacl-sz.py

Issue 1511963002: Subzero: Add a proper default for --pnacl-bin-path . (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/run-pnacl-sz.py
diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py
index 8279772efc3aada2f0613cd224f728e62f3657b3..b7434adc25de0c02c4143e390e16d50ded727bf1 100755
--- a/pydir/run-pnacl-sz.py
+++ b/pydir/run-pnacl-sz.py
@@ -8,7 +8,7 @@ import subprocess
import sys
import tempfile
-from utils import shellcmd
+from utils import FindBaseNaCl, shellcmd
def TargetAssemblerFlags(target, sandboxed):
@@ -60,7 +60,10 @@ def main():
'--pnacl-sz', required=False, default='./pnacl-sz', metavar='PNACL-SZ',
help="Subzero translator 'pnacl-sz'")
argparser.add_argument('--pnacl-bin-path', required=False,
- default=None, metavar='PNACL_BIN_PATH',
+ default=(
+ '{root}/toolchain/linux_x86/pnacl_newlib_raw/bin'
+ ).format(root=FindBaseNaCl()),
+ metavar='PNACL_BIN_PATH',
help='Path to LLVM & Binutils executables ' +
'(e.g. for building PEXE files)')
argparser.add_argument('--assemble', required=False,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698