Timeline: only use public interface of TimelineDetailsContentHelper in generateInvalidationsForType

Timeline: only use public interface of TimelineDetailsContentHelper in generateInvalidationsForType

BUG=

Committed: https://crrev.com/4ade0ba97ccc84adf9ba36163604868aae0e74f6
Cr-Commit-Position: refs/heads/master@{#364626}

[caseq, 2015-12-09 02:00:44]

caseq@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2015-12-09 02:10:19]

lgtm

[caseq, 2015-12-09 02:10:43]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2015-12-09 02:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511843002/1

[caseq, 2015-12-09 02:13:20]

The CQ bit was unchecked by caseq@chromium.org

[pfeldman, 2015-12-09 16:36:38]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-12-09 16:36:39]

There are more misuses of the content helper in the same subsystem, do you want
to fix them?

https://codereview.chromium.org/1511843002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/1511843002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1125:
if (topFrame && this._contentHelper.linkifier()) {
Another misuse of the content helper - should add call stack or location
instead.

https://codereview.chromium.org/1511843002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1147:
this._contentHelper.createChildStackTraceElement(stack, first.cause.stackTrace);
This is also a misuse of the helper. You should only add properties into it.

https://codereview.chromium.org/1511843002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1940:
linkifier: function()
It is easy to spot the abusing call sites - they all use non append* methods
such as this one

https://codereview.chromium.org/1511843002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:2024:
createChildStackTraceElement: function(parentElement, stackTrace)
And this one.

[caseq, 2015-12-11 02:44:31]

The CQ bit was checked by caseq@chromium.org

[caseq, 2015-12-11 02:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/1511843002/#ps20001
(title: "rebased, fixed section style")

[commit-bot: I haz the power, 2015-12-11 02:45:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511843002/20001

[commit-bot: I haz the power, 2015-12-11 06:14:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-11 06:14:47]

Description was changed from

==========
Timeline: only use public interface of TimelineDetailsContentHelper in
generateInvalidationsForType

BUG=
==========

to

==========
Timeline: only use public interface of TimelineDetailsContentHelper in
generateInvalidationsForType

BUG=

Committed: https://crrev.com/4ade0ba97ccc84adf9ba36163604868aae0e74f6
Cr-Commit-Position: refs/heads/master@{#364626}
==========

[commit-bot: I haz the power, 2015-12-11 06:14:48]

Patchset 2 (id:??) landed as
https://crrev.com/4ade0ba97ccc84adf9ba36163604868aae0e74f6
Cr-Commit-Position: refs/heads/master@{#364626}