Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 1511843002: Timeline: only use public interface of TimelineDetailsContentHelper in generateInvalidationsForType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, fixed section style Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 79b3a6350705727efdf5553432f878d47c611145..125fd1d34f0f015db0fe18dd7d9e86c7519a1447 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -970,6 +970,7 @@ WebInspector.TimelineUIUtils._generateCauses = function(event, target, relatedNo
// Indirect causes.
if (event.invalidationTrackingEvents && target) { // Full invalidation tracking (experimental).
+ contentHelper.addSection(WebInspector.UIString("Invalidations"));
WebInspector.TimelineUIUtils._generateInvalidations(event, target, relatedNodesMap, contentHelper);
} else if (initiator && initiator.stackTrace) { // Partial invalidation tracking.
contentHelper.appendStackTrace(callSiteStackLabel || WebInspector.UIString("First Invalidated"), initiator.stackTrace);
@@ -1023,21 +1024,16 @@ WebInspector.TimelineUIUtils._generateInvalidationsForType = function(type, targ
break;
}
- var detailsNode = createElementWithClass("div", "timeline-details-view-row");
- var titleElement = detailsNode.createChild("span", "timeline-details-view-row-title");
- titleElement.textContent = WebInspector.UIString("%s: ", title);
-
var invalidationsTreeOutline = new TreeOutlineInShadow();
invalidationsTreeOutline.registerRequiredCSS("timeline/invalidationsTree.css");
- invalidationsTreeOutline.element.classList.add("timeline-details-view-row-value", "invalidations-tree");
- detailsNode.appendChild(invalidationsTreeOutline.element);
+ invalidationsTreeOutline.element.classList.add("invalidations-tree");
var invalidationGroups = groupInvalidationsByCause(invalidations);
invalidationGroups.forEach(function(group) {
var groupElement = new WebInspector.TimelineUIUtils.InvalidationsGroupElement(target, relatedNodesMap, contentHelper, group);
invalidationsTreeOutline.appendChild(groupElement);
});
- contentHelper.element.appendChild(detailsNode);
+ contentHelper.appendElementRow(title, invalidationsTreeOutline.element, false, true);
/**
* @param {!Array.<!WebInspector.InvalidationTrackingEvent>} invalidations
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698