Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1511833004: Validate that root paths are absolute and normalized. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -21 lines) Patch
M pkg/analysis_server/lib/plugin/protocol/protocol.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +20 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 3 chunks +35 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/util/absolute_path.dart View 3 chunks +70 lines, -7 lines 1 comment Download
M pkg/analyzer/test/src/util/absolute_path_test.dart View 4 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-09 22:34:13 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1511833004/diff/1/pkg/analyzer/lib/src/util/absolute_path.dart File pkg/analyzer/lib/src/util/absolute_path.dart (right): https://codereview.chromium.org/1511833004/diff/1/pkg/analyzer/lib/src/util/absolute_path.dart#newcode135 pkg/analyzer/lib/src/util/absolute_path.dart:135: /// _isAbsolute('/foo/bar/..'); // -> false Wrong method name ...
5 years ago (2015-12-09 22:58:20 UTC) #2
scheglov
5 years ago (2015-12-09 23:05:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e48f962af1c0655758b2405c9dce45a316df95b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698