pkg/analyzer/lib/file_system/physical_file_system.dart - Issue 1511833004: Validate that root paths are absolute and normalized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/file_system/physical_file_system.dart

Issue 1511833004: Validate that root paths are absolute and normalized. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/file_system/physical_file_system.dart

diff --git a/pkg/analyzer/lib/file_system/physical_file_system.dart b/pkg/analyzer/lib/file_system/physical_file_system.dart

index 94aa7667ed9db0451806de772c3d46c58967af23..af405ba9b5b682420292496326619b261b87226e 100644

--- a/pkg/analyzer/lib/file_system/physical_file_system.dart

+++ b/pkg/analyzer/lib/file_system/physical_file_system.dart

@@ -33,7 +33,7 @@ class PhysicalResourceProvider implements ResourceProvider {

static final String SERVER_DIR = ".dartServer";

final AbsolutePathContext absolutePathContext =

- new AbsolutePathContext(io.Platform.pathSeparator);

+ new AbsolutePathContext(io.Platform.isWindows);

PhysicalResourceProvider(String fileReadMode(String s)) {

if (fileReadMode != null) {