Refactor StringImpl::{start,end}sWith(StringImpl*, ...)

Refactor StringImpl::{start,end}sWith(StringImpl*, ...)

In preparation for ASCII case-insensitive matching in these two methods,
add a macro for handling the "dispatch" to the right method, and split
the single method into two in both instances. Make the argument to the
new methods as well as the methods themselves const.
Add equalSubstring{,IgnoringCase} helpers and use those to implement
both of the methods.

BUG=565878
Committed: https://crrev.com/935f4239788702fc9f9c196c6858b1037ed53cc4
Cr-Commit-Position: refs/heads/master@{#364243}

[fs, 2015-12-09 13:31:34]

fs@opera.com changed reviewers:
+ tkent@chromium.org

[fs, 2015-12-09 13:31:35]

Part 2 of https://codereview.chromium.org/1499933003

PTAL

[tkent, 2015-12-10 01:17:16]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-12-10 01:17:16]

lgtm

[commit-bot: I haz the power, 2015-12-10 01:18:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511813004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511813004/1

[commit-bot: I haz the power, 2015-12-10 01:31:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-10 01:31:45]

Description was changed from

==========
Refactor StringImpl::{start,end}sWith(StringImpl*, ...)

In preparation for ASCII case-insensitive matching in these two methods,
add a macro for handling the "dispatch" to the right method, and split
the single method into two in both instances. Make the argument to the
new methods as well as the methods themselves const.
Add equalSubstring{,IgnoringCase} helpers and use those to implement
both of the methods.

BUG=565878
==========

to

==========
Refactor StringImpl::{start,end}sWith(StringImpl*, ...)

In preparation for ASCII case-insensitive matching in these two methods,
add a macro for handling the "dispatch" to the right method, and split
the single method into two in both instances. Make the argument to the
new methods as well as the methods themselves const.
Add equalSubstring{,IgnoringCase} helpers and use those to implement
both of the methods.

BUG=565878

Committed: https://crrev.com/935f4239788702fc9f9c196c6858b1037ed53cc4
Cr-Commit-Position: refs/heads/master@{#364243}
==========

[commit-bot: I haz the power, 2015-12-10 01:31:46]

Patchset 1 (id:??) landed as
https://crrev.com/935f4239788702fc9f9c196c6858b1037ed53cc4
Cr-Commit-Position: refs/heads/master@{#364243}