Use ASCII case-insensitive matching for attribute selectors

Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko (for [1]) and WebKit (for [1] and [2]).

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
Committed: https://crrev.com/bc595d0595a6d1d86a42cd9bc303f6ace91b51e4
Cr-Commit-Position: refs/heads/master@{#364703}

[fs, 2015-12-08 16:47:49]

Description was changed from

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

to

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

[fs, 2015-12-08 21:45:05]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 21:51:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1499933003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1499933003/20001

[commit-bot: I haz the power, 2015-12-09 00:20:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 00:20:47]

Dry run: This issue passed the CQ dry run.

[fs, 2015-12-10 17:06:59]

Description was changed from

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

to

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko and WebKit.

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

[fs, 2015-12-10 17:09:33]

Description was changed from

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko and WebKit.

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

to

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko (for [1]) and WebKit (for [1][2]).

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

[fs, 2015-12-10 17:27:09]

Description was changed from

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko (for [1]) and WebKit (for [1][2]).

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

to

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko (for [1]) and WebKit (for [1] and [2]).

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

[fs, 2015-12-10 17:29:10]

fs@opera.com changed reviewers:
+ esprehn@chromium.org, tkent@chromium.org

[fs, 2015-12-10 17:29:11]

PTAL

I'll try to get selectors/attribute-selectors/attribute-case/ from w-p-t
imported too, so some additional tests will come in that way.

[tkent, 2015-12-11 00:02:45]

lgtm

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/WTFString.h (right):

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/WTFString.h:90: (caseSensitivity ==
TextCaseASCIIInsensitive) ? op##IgnoringASCIICase args : \
I was afraid the code size bloat by this.  However, |caseSensitivity| flag is
usually a constant value, and we can expect compilers eliminate unnecessary
code.  So, this is ok.

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/WTFStringTest.cpp (right):

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/WTFStringTest.cpp:361: TEST(WTF,
EqualIgnoringASCIICase)
WTF -> StringTest

[esprehn, 2015-12-11 10:17:46]

lgtm

[fs, 2015-12-11 11:43:16]

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/WTFString.h (right):

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/WTFString.h:90: (caseSensitivity ==
TextCaseASCIIInsensitive) ? op##IgnoringASCIICase args : \
On 2015/12/11 at 00:02:45, tkent wrote:
> I was afraid the code size bloat by this.  However, |caseSensitivity| flag is
usually a constant value, and we can expect compilers eliminate unnecessary
code.  So, this is ok.

Yes, this was how I reasoned about it as well.

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/WTFStringTest.cpp (right):

https://codereview.chromium.org/1499933003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/WTFStringTest.cpp:361: TEST(WTF,
EqualIgnoringASCIICase)
On 2015/12/11 at 00:02:45, tkent wrote:
> WTF -> StringTest

Done.

[fs, 2015-12-11 13:19:53]

The CQ bit was checked by fs@opera.com

[fs, 2015-12-11 13:19:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1499933003/#ps60001
(title: "WTF -> StringTest")

[commit-bot: I haz the power, 2015-12-11 13:20:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1499933003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1499933003/60001

[commit-bot: I haz the power, 2015-12-11 14:52:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-11 14:53:34]

Description was changed from

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko (for [1]) and WebKit (for [1] and [2]).

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878
==========

to

==========
Use ASCII case-insensitive matching for attribute selectors

When matching attribute selectors in a case-insensitive manner, the
match should be performed using "ASCII case-insensitive" matching per
the "document language" specification (HTML) [1]. Similarly when the "i"
modifier is used [2].

New behavior matches Gecko (for [1]) and WebKit (for [1] and [2]).

This requires adding some new functions to support the various matching
operations: startsWith, endsWith and find.
Add TextCaseSensitivity value TextCaseASCIIInsensitive and
implementations for the methods mentioned above.
Replace current use of startsWithIgnoringASCIICase with startsWith,
passing TextCaseASCIIInsensitive.

[1] https://html.spec.whatwg.org/multipage/scripting.html#case-sensitivity
[2] https://drafts.csswg.org/selectors-4/#attribute-case

BUG=565878

Committed: https://crrev.com/bc595d0595a6d1d86a42cd9bc303f6ace91b51e4
Cr-Commit-Position: refs/heads/master@{#364703}
==========

[commit-bot: I haz the power, 2015-12-11 14:53:35]

Patchset 4 (id:??) landed as
https://crrev.com/bc595d0595a6d1d86a42cd9bc303f6ace91b51e4
Cr-Commit-Position: refs/heads/master@{#364703}