Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1511773006: Revert of Implement helper functionalities for computing image size with ES3 settings. (Closed)

Created:
5 years ago by Zhenyao Mo
Modified:
5 years ago
CC:
chromium-reviews, piman+watch_chromium.org, yunchao, Ken Russell (switch to Gerrit), bajones, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement helper functionalities for computing image size with ES3 settings. (patchset #6 id:140001 of https://codereview.chromium.org/1508953002/ ) Reason for revert: Jamie thinks this caused the GLES2ConformTest.GL2FixedTests_divide_by_zero_input_run test to fail on FYI waterfall Original issue's description: > Implement helper functionalities for computing image size with ES3 settings. > > This will be used in ReadPixels, Tex{Sub}Image* in followup CLs. > > BUG=429053, 563714 > TEST=gpu_unittests > R=piman@chromium.org > > Committed: https://crrev.com/e0b58d1f24bce6a6f19dcbe5e857e3731d0631ca > Cr-Commit-Position: refs/heads/master@{#364095} TBR=piman@chromium.org,kbr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429053, 563714 Committed: https://crrev.com/ce844811f91dcdf3744e5ec97eff4cd5bdc49880 Cr-Commit-Position: refs/heads/master@{#364119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -310 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.h View 3 chunks +6 lines, -37 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +40 lines, -126 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 2 chunks +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Zhenyao Mo
Created Revert of Implement helper functionalities for computing image size with ES3 settings.
5 years ago (2015-12-09 19:08:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511773006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511773006/1
5 years ago (2015-12-09 19:13:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 19:17:13 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-09 19:18:42 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce844811f91dcdf3744e5ec97eff4cd5bdc49880
Cr-Commit-Position: refs/heads/master@{#364119}

Powered by Google App Engine
This is Rietveld 408576698