Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 151173004: IDL compiler: [GarbageCollected] on other interface (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [GarbageCollected] on other interface [GarbageCollected] affects not only bindings a given interface (and descendants), but also bindings for all interfaces that *use* it: it's external information. Add support to compute_dependencies.py for this; since we already inherit [GarbageCollected], it's just a matter of making the code more generic. BUG=239771 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166598

Patch Set 1 #

Patch Set 2 : Reupload #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -58 lines) Patch
M Source/bindings/scripts/compute_dependencies.py View 4 chunks +21 lines, -19 lines 2 comments Download
M Source/bindings/scripts/unstable/code_generator_v8.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_types.py View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceCheckSecurity.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterfacePython.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 6 chunks +10 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 5 chunks +63 lines, -28 lines 0 comments Download
M Source/modules/gamepad/GamepadList.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-06 03:20:59 UTC) #1
haraken
LGTM https://codereview.chromium.org/151173004/diff/30001/Source/bindings/scripts/compute_dependencies.py File Source/bindings/scripts/compute_dependencies.py (right): https://codereview.chromium.org/151173004/diff/30001/Source/bindings/scripts/compute_dependencies.py#newcode54 Source/bindings/scripts/compute_dependencies.py:54: interfaces_info = {} Would you add a comment ...
6 years, 10 months ago (2014-02-06 03:57:37 UTC) #2
Nils Barth (inactive)
https://codereview.chromium.org/151173004/diff/30001/Source/bindings/scripts/compute_dependencies.py File Source/bindings/scripts/compute_dependencies.py (right): https://codereview.chromium.org/151173004/diff/30001/Source/bindings/scripts/compute_dependencies.py#newcode54 Source/bindings/scripts/compute_dependencies.py:54: interfaces_info = {} On 2014/02/06 03:57:38, haraken wrote: > ...
6 years, 10 months ago (2014-02-06 04:49:06 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-06 04:49:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/151173004/30001
6 years, 10 months ago (2014-02-06 04:49:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 06:54:01 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=25977
6 years, 10 months ago (2014-02-06 06:54:02 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-06 09:00:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/151173004/30001
6 years, 10 months ago (2014-02-06 09:00:20 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 10:42:10 UTC) #10
Message was sent while issue was closed.
Change committed as 166598

Powered by Google App Engine
This is Rietveld 408576698