IDL compiler: [GarbageCollected] on other interface

Source/bindings/scripts/compute_dependencies.py

 #!/usr/bin/python
 #
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 33 matching lines @@
     'GarbageCollected',
 ])
 
 
 # interfaces_info is *exported* (in a pickle), and should only contain data
 # about an interface that contains paths or is needed by *other* interfaces,
 # i.e., file layout data (to abstract the compiler from file paths) or
 # public data (to avoid having to read other interfaces unnecessarily).
 # It should *not* contain full information about an interface (e.g., all
 # extended attributes), as this would cause unnecessary rebuilds.
 interfaces_info = {}

[haraken, 2014/02/06 03:57:38]

Would you add a comment about what information is in interfaces_info
specifically?

[Nils Barth (inactive), 2014/02/06 04:49:06]

n/p, done!

 
 # Auxiliary variables (not visible to future build steps)
 partial_interface_files = {}
 parent_interfaces = {}
 extended_attributes_by_interface = {}  # interface name -> extended attributes
 
 
 class IdlBadFilenameError(Exception):
     """Raised if an IDL filename disagrees with the interface name in the file."""
     pass
@@ skipping 342 matching lines @@
 
     return attributes_list
 
 
 def record_global_constructors_and_extended_attributes(idl_filename, global_constructors):
     interface_name, _ = os.path.splitext(os.path.basename(idl_filename))
     full_path = os.path.realpath(idl_filename)
     idl_file_contents = get_file_contents(full_path)
     extended_attributes = get_interface_extended_attributes_from_idl(idl_file_contents)
 
+    # Record extended attributes
+    extended_attributes_by_interface[interface_name] = extended_attributes
+
     # Record global constructors
-    if not is_callback_interface_from_idl(idl_file_contents) and 'NoInterfaceObject' not in extended_attributes:
+    if (not is_callback_interface_from_idl(idl_file_contents) and
+        'NoInterfaceObject' not in extended_attributes):
         global_contexts = extended_attributes.get('GlobalContext', 'Window').split('&')
         new_constructor_list = generate_constructor_attribute_list(interface_name, extended_attributes)
         for global_object in global_contexts:
             global_constructors[global_object].extend(new_constructor_list)
 
-    # Record parents and extended attributes for generating event names
+    # Record parents
     parent = get_parent_interface(idl_file_contents)
     if parent:
         parent_interfaces[interface_name] = parent
-    if parent or interface_name == 'Event':
-        extended_attributes_by_interface[interface_name] = extended_attributes
 
 
 def record_extended_attributes(idl_filename):
     interface_name, _ = os.path.splitext(os.path.basename(idl_filename))
     full_path = os.path.realpath(idl_filename)
     idl_file_contents = get_file_contents(full_path)
     extended_attributes = get_interface_extended_attributes_from_idl(idl_file_contents)
     extended_attributes_by_interface[interface_name] = extended_attributes
 
 
 def generate_ancestors_and_inherited_extended_attributes(interface_name):
     interface_info = interfaces_info[interface_name]
+    interface_extended_attributes = extended_attributes_by_interface[interface_name]
+    inherited_extended_attributes = dict(
+            (key, value)
+            for key, value in interface_extended_attributes.iteritems()
+            if key in INHERITED_EXTENDED_ATTRIBUTES)
 
     def generate_ancestors(interface_name):
         while interface_name in parent_interfaces:
             interface_name = parent_interfaces[interface_name]
             yield interface_name
 
     ancestors = list(generate_ancestors(interface_name))
+    if not ancestors:
+        if inherited_extended_attributes:
+            interface_info['inherited_extended_attributes'] = inherited_extended_attributes
+        return
+
     interface_info['ancestors'] = ancestors
-
-    # Base interface (most distant ancestor) has no parent, and thus its
-    # extended attributes may not yet be recorded.
-    base_interface_name = ancestors[-1]
-    if base_interface_name not in extended_attributes_by_interface:
-        if base_interface_name not in interfaces_info:
-            # Absent for support files
-            return
-        base_interface_info = interfaces_info[base_interface_name]
-        base_interface_filename = base_interface_info['full_path']
-        record_extended_attributes(base_interface_filename)
-
-    inherited_extended_attributes = {}
     for ancestor in ancestors:
-        ancestor_extended_attributes = extended_attributes_by_interface[ancestor]
+        # Extended attributes are missing if an ancestor is an interface that
+        # we're not processing, notably real IDL files if only processing test
+        # IDL files, or generated support files.
+        ancestor_extended_attributes = extended_attributes_by_interface.get(ancestor, {})
         inherited_extended_attributes.update(dict(
             (key, value)
             for key, value in ancestor_extended_attributes.iteritems()
             if key in INHERITED_EXTENDED_ATTRIBUTES))
     if inherited_extended_attributes:
         interface_info['inherited_extended_attributes'] = inherited_extended_attributes
 
 
 def parse_idl_files(idl_files, global_constructors_filenames):
     """Compute dependencies between IDL files, and return constructors on global objects.
@@ skipping 11 matching lines @@
         (global_object, [])
         for global_object in global_constructors_filenames])
 
     # Generate dependencies, and (for main IDL files), record
     # global_constructors and extended_attributes_by_interface.
     for idl_filename in idl_files:
         # Test skips partial interfaces
         if generate_dependencies(idl_filename):
             record_global_constructors_and_extended_attributes(idl_filename, global_constructors)
 
-    for interface_name in parent_interfaces:
+    for interface_name in interfaces_info:
         generate_ancestors_and_inherited_extended_attributes(interface_name)
 
     # Add constructors on global objects to partial interfaces
     # These are all partial interfaces, but the files are dynamically generated,
     # so they need to be handled separately from static partial interfaces.
     for global_object, constructor_filename in global_constructors_filenames.iteritems():
         if global_object in interfaces_info:
             # No include path needed, as already included in the header file
             add_paths_to_partials_dict(global_object, constructor_filename)
 
@@ skipping 48 matching lines @@
     write_dependencies_file(options.interface_dependencies_file, only_if_changed)
     write_pickle_file(options.interfaces_info_file, interfaces_info, only_if_changed)
     for interface_name, filename in global_constructors_filenames.iteritems():
         if interface_name in interfaces_info:
             write_global_constructors_partial_interface(interface_name, filename, global_constructors[interface_name], only_if_changed)
     write_event_names_file(options.event_names_file, only_if_changed)
 
 
 if __name__ == '__main__':
     main()