Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 1511643002: spin off remaining integer overflow fixes (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

spin off remaining integer overflow fixes - Carmack rsqrt uses an int where it wants a uint32_t. - turn off all santizers (including signed-integer-overflow) in third_party/externals/sftntly. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot BUG=skia:4635 Committed: https://skia.googlesource.com/skia/+/1f6a1bd969db92daa5fa60517d6b8fc6eef8cb61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M bench/MathBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/sfntly.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mtklein_C
These are the signed-integer-overflow-specific parts of https://codereview.chromium.org/1510683002
5 years ago (2015-12-08 18:15:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511643002/1
5 years ago (2015-12-08 18:15:58 UTC) #5
tomhudson
lgtm
5 years ago (2015-12-08 18:22:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511643002/1
5 years ago (2015-12-08 18:23:23 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-08 18:53:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1f6a1bd969db92daa5fa60517d6b8fc6eef8cb61

Powered by Google App Engine
This is Rietveld 408576698