bench/MathBench.cpp - Issue 1511643002: spin off remaining integer overflow fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/MathBench.cpp

Issue 1511643002: spin off remaining integer overflow fixes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/MathBench.cpp

diff --git a/bench/MathBench.cpp b/bench/MathBench.cpp

index a5cc033c6fc63f72c9d4f707da1a69533190413f..fb35a8aafec786df3967e2af4f1343afb8a7c722 100644

--- a/bench/MathBench.cpp

+++ b/bench/MathBench.cpp

@@ -126,7 +126,7 @@ private:

static inline float SkFastInvSqrt(float x) {

float xhalf = 0.5f*x;

- int i = *SkTCast<int*>(&x);

+ uint32_t i = *SkTCast<uint32_t*>(&x);

i = 0x5f3759df - (i>>1);

x = *SkTCast<float*>(&i);

x = x*(1.5f-xhalf*x*x);

« no previous file with comments | « no previous file | gyp/sfntly.gyp » ('j') | no next file with comments »