Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1511603002: Merge to m48: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mix… (Closed)

Created:
5 years ago by nektarios
Modified:
5 years ago
CC:
nektarios, aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, extensions-reviews_chromium.org, jam, je_julie, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Merge to m48: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state. On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object whenever it represents an input control in an indeterminate state. However, the official documentation at https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx doesn't list SYSTEM_STATE_INDETERMINATE and if you look into the header file for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value as SYSTEM_STATE_MIXED. I found some discussion on an IA2 mailing list for adding this state to IA2, but the discussion didn't lead to anywhere as far as I can tell. BUG=521875 TESTED=browser tests,manually using Jaws NOTRY=true NOPRESUBMIT=true R=dmazzoni@chromium.org, avi@chromium.org Review URL: https://codereview.chromium.org/1488893002 Cr-Commit-Position: refs/heads/master@{#362631} (cherry picked from commit f5ebe8c02f6a79691503fa48614b566a75bcbd0c) Conflicts: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -83 lines) Patch
M chrome/common/extensions/api/automation.idl View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-checkbox.html View 1 chunk +10 lines, -3 lines 0 comments Download
M content/test/data/accessibility/html/input-checkbox-expected-android.txt View 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/data/accessibility/html/input-checkbox-expected-mac.txt View 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/data/accessibility/html/input-checkbox-expected-win.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/input-checkbox-in-menu.html View 1 chunk +15 lines, -6 lines 0 comments Download
M content/test/data/accessibility/html/input-checkbox-in-menu-expected-android.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/input-checkbox-in-menu-expected-mac.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/input-checkbox-in-menu-expected-win.txt View 1 chunk +6 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/input-radio-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/html/input-radio-in-menu-expected-win.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 3 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/ax_enums.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nektarios
5 years ago (2015-12-08 17:08:32 UTC) #1
nektarios
5 years ago (2015-12-09 00:53:32 UTC) #4
dmazzoni
lgtm
5 years ago (2015-12-10 05:16:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511603002/1
5 years ago (2015-12-10 14:23:34 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-10 14:26:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698