Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object whenever it represents an input control in an indeterminate state.
However, the official documentation at https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx doesn't list SYSTEM_STATE_INDETERMINATE  and if you look into the header file for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value as SYSTEM_STATE_MIXED.
I found some discussion on an IA2 mailing list for adding this state to IA2, but the discussion didn't lead to anywhere as far as I can tell.
BUG=521875
TESTED=browser tests,manually using Jaws
R=dmazzoni@chromium.org
TBR=mkwst

Committed: https://crrev.com/f5ebe8c02f6a79691503fa48614b566a75bcbd0c
Cr-Commit-Position: refs/heads/master@{#362631}

[dmazzoni, 2015-12-01 16:54:00]

The spec says that INDETERMINATE is correct, see here:

http://www.w3.org/TR/html-aapi/

Could you check what Firefox does? What's some sample html that's broken and how
is it broken? What about with NVDA?

[dmazzoni, 2015-12-01 16:54:54]

I suspect the bug may be that internally we treat unselected radio buttons in an
indeterminate state but that isn't the correct mapping for Windows. That doesn't
mean we should support SYSTEM_STATE_INDETERMINATE in other valid cases.

[chromium-reviews, 2015-12-01 19:24:56]

On 12/1/2015 11:54 AM, dmazzoni@chromium.org wrote:
> I suspect the bug may be that internally we treat unselected radio 
> buttons in an
> indeterminate state but that isn't the correct mapping for Windows. 
> That doesn't
> mean we should support SYSTEM_STATE_INDETERMINATE in other valid cases.
>
But there are no other valid cases I have found.
SYSTEM_STATE_INDETERMINATE is not documented on MSDn. On HTML to 
Platform Accessibility it's only mentioned as part of ATK. For IA2 they 
talk about SYSTEM_STATE_MIXED, which we already expose for buttons and 
with my patch I extended it to check boxes.
Only three controls are listed on HTML to Platform Accessibility that 
can have this state: Checkboxes, menu check boxes and progress bars. For 
IA2, this state is always exposed as SYSTEM_STATE_MIXED.
My patch exposes SYSTEM_STATE_MIXED for check boxes. I guess progress 
bars and menu check boxes were never supported in that state in the 
current implementation. I will look into adding support for them too.
As far as the Blink function isIndeterminate, I think we should remove 
it because for check boxes, toggle buttons and menu check boxes, we 
already have isMixed. For progress bars, we could look into modifying 
the function that returns the control's value for signifying 
indeterminate state.
What do you think?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-12-01 19:37:25]

OK, got it. I checked the docs and it looks like indeterminate really does only
apply to check boxes so this sounds fine.

Please remove "indeterminate" from ax_enums.idl, automation.idl, and from
everywhere else that references those as part of this change.

[chromium-reviews, 2015-12-01 21:06:01]

Indeterminate removed from everywhere.
Tests added for menu check boxes.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-12-01 21:57:32]

https://codereview.chromium.org/1488893002/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1488893002/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:4211: if
(GetBoolAttribute(ui::AX_ATTR_CHECKBOX_MIXED))
Hmmm, by changing BUTTON_MIXED to CHECKBOX_MIXED, what happened to support for
<button aria-pressed="mixed">?

[chromium-reviews, 2015-12-01 22:19:58]

>
https://codereview.chromium.org/1488893002/diff/40001/content/browser/accessi...

>
> content/browser/accessibility/browser_accessibility_win.cc:4211: if
> (GetBoolAttribute(ui::AX_ATTR_CHECKBOX_MIXED))
> Hmmm, by changing BUTTON_MIXED to CHECKBOX_MIXED, what happened to
> support for <button aria-pressed="mixed">?

Oh, it seems that it was never supported.
AXObject::isPressed returns true for the mixed state.
I guess I should support that too?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-12-01 23:13:38]

Description was changed from

==========
Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have
a mixed state.

On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object
whenever it represents an input control in an indeterminate state.
However, the official documentation at
https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx
doesn't list SYSTEM_STATE_INDETERMINATE  and if you look into the header file
for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value
as SYSTEM_STATE_MIXED.
I found some discussion on an IA2 mailing list for adding this state to IA2, but
the discussion didn't lead to anywhere as far as I can tell.
BUG=521875
TESTED=browser tests,manually using Jaws
R=dmazzoni@chromium.org
==========

to

==========
Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have
a mixed state.

On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object
whenever it represents an input control in an indeterminate state.
However, the official documentation at
https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx
doesn't list SYSTEM_STATE_INDETERMINATE  and if you look into the header file
for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value
as SYSTEM_STATE_MIXED.
I found some discussion on an IA2 mailing list for adding this state to IA2, but
the discussion didn't lead to anywhere as far as I can tell.
BUG=521875
TESTED=browser tests,manually using Jaws
R=dmazzoni@chromium.org
TBR=mkwst
==========

[dmazzoni, 2015-12-01 23:13:54]

lgtm

You're right, it didn't seem to be supported before. Thanks.

[chromium-reviews, 2015-12-01 23:15:48]

I renamed AX_ATTR_CHECKBOX_MIXED to AX_ATTR_STATE_MIXED and I'll use it 
to expose ARIA toggle buttons too in a future patch.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2015-12-02 02:59:21]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-12-02 02:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1488893002/#ps140001
(title: "Fixed a few test expectations.")

[commit-bot: I haz the power, 2015-12-02 02:59:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488893002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488893002/140001

[commit-bot: I haz the power, 2015-12-02 04:30:49]

Description was changed from

==========
Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have
a mixed state.

On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object
whenever it represents an input control in an indeterminate state.
However, the official documentation at
https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx
doesn't list SYSTEM_STATE_INDETERMINATE  and if you look into the header file
for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value
as SYSTEM_STATE_MIXED.
I found some discussion on an IA2 mailing list for adding this state to IA2, but
the discussion didn't lead to anywhere as far as I can tell.
BUG=521875
TESTED=browser tests,manually using Jaws
R=dmazzoni@chromium.org
TBR=mkwst
==========

to

==========
Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have
a mixed state.

On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object
whenever it represents an input control in an indeterminate state.
However, the official documentation at
https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx
doesn't list SYSTEM_STATE_INDETERMINATE  and if you look into the header file
for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value
as SYSTEM_STATE_MIXED.
I found some discussion on an IA2 mailing list for adding this state to IA2, but
the discussion didn't lead to anywhere as far as I can tell.
BUG=521875
TESTED=browser tests,manually using Jaws
R=dmazzoni@chromium.org
TBR=mkwst
==========

[commit-bot: I haz the power, 2015-12-02 04:30:49]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-12-02 04:31:50]

Description was changed from

==========
Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have
a mixed state.

On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object
whenever it represents an input control in an indeterminate state.
However, the official documentation at
https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx
doesn't list SYSTEM_STATE_INDETERMINATE  and if you look into the header file
for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value
as SYSTEM_STATE_MIXED.
I found some discussion on an IA2 mailing list for adding this state to IA2, but
the discussion didn't lead to anywhere as far as I can tell.
BUG=521875
TESTED=browser tests,manually using Jaws
R=dmazzoni@chromium.org
TBR=mkwst
==========

to

==========
Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have
a mixed state.

On Windows, we set SYSTEM_STATE_INDETERMINATE on an accessibility object
whenever it represents an input control in an indeterminate state.
However, the official documentation at
https://msdn.microsoft.com/en-us/library/windows/desktop/dd373609(v=vs.85).aspx
doesn't list SYSTEM_STATE_INDETERMINATE  and if you look into the header file
for IAccessible you observe that SYSTEM_STATE_INDETERMINATE has the same value
as SYSTEM_STATE_MIXED.
I found some discussion on an IA2 mailing list for adding this state to IA2, but
the discussion didn't lead to anywhere as far as I can tell.
BUG=521875
TESTED=browser tests,manually using Jaws
R=dmazzoni@chromium.org
TBR=mkwst

Committed: https://crrev.com/f5ebe8c02f6a79691503fa48614b566a75bcbd0c
Cr-Commit-Position: refs/heads/master@{#362631}
==========

[commit-bot: I haz the power, 2015-12-02 04:31:51]

Patchset 8 (id:??) landed as
https://crrev.com/f5ebe8c02f6a79691503fa48614b566a75bcbd0c
Cr-Commit-Position: refs/heads/master@{#362631}