[Offline pages] Remove references to MessageLoop from components/offline_pages

[Offline pages] Remove references to MessageLoop from components/offline_pages

Replaces references to the MessageLoop::current with
base::ThreadTaskRunnerHandle
* In offline_page_model_unittest it uses TestMockTimeTaskRunner
* In offline_page_metadata_store_impl_unittest it uses
  TestSimpleTaskRunner

BUG=565577
R=jianli@chromium.org

Committed: https://crrev.com/0abc7bc07b778e12ffdce09cd157a3a1d77ccee6
Cr-Commit-Position: refs/heads/master@{#364262}

[fgorski, 2015-12-08 23:13:28]

PTAL

[jianli, 2015-12-08 23:25:25]

lgtm

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_metadata_store_impl.cc (right):

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_metadata_store_impl.cc:218:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
nit: include base/thread_task_runner_handle.h

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_metadata_store_impl_unittest.cc
(right):

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_metadata_store_impl_unittest.cc:39: void
TearDown() override { task_runner_->RunUntilIdle(); }
Is this needed now? If yes, call PumpLoop instead.

[fgorski, 2015-12-08 23:39:14]

Addressed

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_metadata_store_impl.cc (right):

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_metadata_store_impl.cc:218:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
On 2015/12/08 23:25:25, jianli wrote:
> nit: include base/thread_task_runner_handle.h

It is actually already there, but it was not used :) I noticed that the first
time I was trying to add it.

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_metadata_store_impl_unittest.cc
(right):

https://codereview.chromium.org/1511483004/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_metadata_store_impl_unittest.cc:39: void
TearDown() override { task_runner_->RunUntilIdle(); }
On 2015/12/08 23:25:25, jianli wrote:
> Is this needed now? If yes, call PumpLoop instead.

Done. This is needed for the lsan tests. We have to wait for the level_db store
to delete itself. Added a comment.

[fgorski, 2015-12-09 18:45:31]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2015-12-09 18:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from jianli@chromium.org
Link to the patchset: https://codereview.chromium.org/1511483004/#ps40001
(title: "Fixing missing dependency")

[commit-bot: I haz the power, 2015-12-09 18:47:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511483004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511483004/40001

[commit-bot: I haz the power, 2015-12-09 19:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 19:37:41]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fgorski, 2015-12-09 19:39:15]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2015-12-09 19:40:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511483004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511483004/40001

[commit-bot: I haz the power, 2015-12-09 21:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 21:01:46]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fgorski, 2015-12-10 01:45:38]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2015-12-10 01:46:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511483004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511483004/40001

[commit-bot: I haz the power, 2015-12-10 02:20:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-10 02:21:45]

Description was changed from

==========
[Offline pages] Remove references to MessageLoop from components/offline_pages

Replaces references to the MessageLoop::current with
base::ThreadTaskRunnerHandle
* In offline_page_model_unittest it uses TestMockTimeTaskRunner
* In offline_page_metadata_store_impl_unittest it uses
  TestSimpleTaskRunner

BUG=565577
R=jianli@chromium.org
==========

to

==========
[Offline pages] Remove references to MessageLoop from components/offline_pages

Replaces references to the MessageLoop::current with
base::ThreadTaskRunnerHandle
* In offline_page_model_unittest it uses TestMockTimeTaskRunner
* In offline_page_metadata_store_impl_unittest it uses
  TestSimpleTaskRunner

BUG=565577
R=jianli@chromium.org

Committed: https://crrev.com/0abc7bc07b778e12ffdce09cd157a3a1d77ccee6
Cr-Commit-Position: refs/heads/master@{#364262}
==========

[commit-bot: I haz the power, 2015-12-10 02:21:46]

Patchset 3 (id:??) landed as
https://crrev.com/0abc7bc07b778e12ffdce09cd157a3a1d77ccee6
Cr-Commit-Position: refs/heads/master@{#364262}