[Offline pages] Refactoring helper classes out from offline_page_model_unittest.cc

[Offline pages] Refactoring helper classes out from offline_page_model_unittest.cc

This patch extracts helper test classes from offline_page_model_unittest:
* OfflinePageTestStore
* OfflinePageTestArchiver

BUG=567356
Committed: https://crrev.com/38601ab6492c9f62332918ecb3bd3846db3a124f
Cr-Commit-Position: refs/heads/master@{#363832}

[fgorski, 2015-12-07 23:01:05]

fgorski@chromium.org changed reviewers:
+ jianli@chromium.org

[fgorski, 2015-12-07 23:01:06]

PTAL

[jianli, 2015-12-07 23:19:02]

lgtm

You also need to update BUILD.gn.

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_test_archiver.h (right):

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_archiver.h:46: void set_delayed(bool
delayed) { delayed_ = delayed; }
Please comment on what this is meant.

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_archiver.h:60:
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
nit: add empty line

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_test_store.cc (right):

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_store.cc:27: if (scenario_ !=
TestScenario::LOAD_FAILED) {
suggest to flip the if test for easier understanding:
  if (scenario_ == TestScenario::LOAD_FAILED) {
    ...
  } else {
    ...
  }

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_store.cc:42: if (result) {
nit: brackets not needed

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_test_store.h (right):

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_store.h:61:
DISALLOW_ASSIGN(OfflinePageTestStore);
DISALLOW_COPY_AND_ASSIGN?

[fgorski, 2015-12-08 00:33:56]

PTAL.

Addressed and updated the gn/gyp files.

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_test_archiver.h (right):

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_archiver.h:46: void set_delayed(bool
delayed) { delayed_ = delayed; }
On 2015/12/07 23:19:01, jianli wrote:
> Please comment on what this is meant.

Done.

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_archiver.h:60:
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
On 2015/12/07 23:19:01, jianli wrote:
> nit: add empty line

Done.

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_test_store.cc (right):

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_store.cc:27: if (scenario_ !=
TestScenario::LOAD_FAILED) {
On 2015/12/07 23:19:01, jianli wrote:
> suggest to flip the if test for easier understanding:
>   if (scenario_ == TestScenario::LOAD_FAILED) {
>     ...
>   } else {
>     ...
>   }
> 

Done.

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_store.cc:42: if (result) {
On 2015/12/07 23:19:01, jianli wrote:
> nit: brackets not needed

Done.

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_test_store.h (right):

https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_test_store.h:61:
DISALLOW_ASSIGN(OfflinePageTestStore);
On 2015/12/07 23:19:02, jianli wrote:
> DISALLOW_COPY_AND_ASSIGN?

There is a copy constructor defined above so I don't redefine it here.

[fgorski, 2015-12-08 17:11:03]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2015-12-08 17:11:03]

The patchset sent to the CQ was uploaded after l-g-t-m from jianli@chromium.org
Link to the patchset: https://codereview.chromium.org/1504243002/#ps20001
(title: "Fixing gn build and addressing comments")

[commit-bot: I haz the power, 2015-12-08 17:12:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504243002/20001

[commit-bot: I haz the power, 2015-12-08 18:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 18:06:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fgorski, 2015-12-08 21:34:32]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2015-12-08 21:44:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504243002/20001

[commit-bot: I haz the power, 2015-12-08 23:30:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-08 23:31:56]

Description was changed from

==========
[Offline pages] Refactoring helper classes out from
offline_page_model_unittest.cc

This patch extracts helper test classes from offline_page_model_unittest:
* OfflinePageTestStore
* OfflinePageTestArchiver

BUG=567356
==========

to

==========
[Offline pages] Refactoring helper classes out from
offline_page_model_unittest.cc

This patch extracts helper test classes from offline_page_model_unittest:
* OfflinePageTestStore
* OfflinePageTestArchiver

BUG=567356

Committed: https://crrev.com/38601ab6492c9f62332918ecb3bd3846db3a124f
Cr-Commit-Position: refs/heads/master@{#363832}
==========

[commit-bot: I haz the power, 2015-12-08 23:31:57]

Patchset 2 (id:??) landed as
https://crrev.com/38601ab6492c9f62332918ecb3bd3846db3a124f
Cr-Commit-Position: refs/heads/master@{#363832}