Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1504243002: [Offline pages] Refactoring helper classes out from offline_page_model_unittest.cc (Closed)

Created:
5 years ago by fgorski
Modified:
5 years ago
Reviewers:
jianli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Refactoring helper classes out from offline_page_model_unittest.cc This patch extracts helper test classes from offline_page_model_unittest: * OfflinePageTestStore * OfflinePageTestArchiver BUG=567356 Committed: https://crrev.com/38601ab6492c9f62332918ecb3bd3846db3a124f Cr-Commit-Position: refs/heads/master@{#363832}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fixing gn build and addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -191 lines) Patch
M components/components_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages.gypi View 1 1 chunk +17 lines, -0 lines 0 comments Download
M components/offline_pages/BUILD.gn View 1 2 chunks +18 lines, -0 lines 0 comments Download
M components/offline_pages/offline_page_model_unittest.cc View 7 chunks +13 lines, -191 lines 0 comments Download
A components/offline_pages/offline_page_test_archiver.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A components/offline_pages/offline_page_test_archiver.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A components/offline_pages/offline_page_test_store.h View 1 chunk +66 lines, -0 lines 0 comments Download
A components/offline_pages/offline_page_test_store.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
fgorski
PTAL
5 years ago (2015-12-07 23:01:06 UTC) #2
jianli
lgtm You also need to update BUILD.gn. https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/offline_page_test_archiver.h File components/offline_pages/offline_page_test_archiver.h (right): https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/offline_page_test_archiver.h#newcode46 components/offline_pages/offline_page_test_archiver.h:46: void set_delayed(bool ...
5 years ago (2015-12-07 23:19:02 UTC) #3
fgorski
PTAL. Addressed and updated the gn/gyp files. https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/offline_page_test_archiver.h File components/offline_pages/offline_page_test_archiver.h (right): https://codereview.chromium.org/1504243002/diff/1/components/offline_pages/offline_page_test_archiver.h#newcode46 components/offline_pages/offline_page_test_archiver.h:46: void set_delayed(bool ...
5 years ago (2015-12-08 00:33:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504243002/20001
5 years ago (2015-12-08 17:12:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/98771)
5 years ago (2015-12-08 18:06:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504243002/20001
5 years ago (2015-12-08 21:44:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-08 23:30:17 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-08 23:31:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38601ab6492c9f62332918ecb3bd3846db3a124f
Cr-Commit-Position: refs/heads/master@{#363832}

Powered by Google App Engine
This is Rietveld 408576698