Improve CodeRegionTable build time by 30x

runtime/vm/isolate.cc

Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index bb493ab7508f0a6fb313db217925e7cd5335cfa7..1b656f11099c57ef4b872d473b1419bba44712f6 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -479,15 +479,15 @@ void Isolate::SetStackLimit(uword limit) {
 }
 
 
-bool Isolate::GetStackBounds(uintptr_t* lower, uintptr_t* upper) {
-  uintptr_t stack_lower = stack_limit();
-  if (stack_lower == static_cast<uintptr_t>(~0)) {
+bool Isolate::GetStackBounds(uword* lower, uword* upper) {
+  uword stack_lower = stack_limit();
+  if (stack_lower == static_cast<uword>(~0)) {

[siva, 2014/02/19 18:09:54]

should this be
if (stack_lower == kUwordMax) {
  ....
}

[Cutch, 2014/02/19 18:20:31]

Done.

     stack_lower = saved_stack_limit();
   }
-  if (stack_lower == static_cast<uintptr_t>(~0)) {
+  if (stack_lower == static_cast<uword>(~0)) {

[siva, 2014/02/19 18:09:54]

Ditto...

[Cutch, 2014/02/19 18:20:31]

Done.

     return false;
   }
-  uintptr_t stack_upper = stack_lower + GetSpecifiedStackSize();
+  uword stack_upper = stack_lower + GetSpecifiedStackSize();
   *lower = stack_lower;
   *upper = stack_upper;
   return true;